Handle suggestions that are substrings of first suggestion#913
Closed
ysthakur wants to merge 3 commits intonushell:mainfrom
Closed
Handle suggestions that are substrings of first suggestion#913ysthakur wants to merge 3 commits intonushell:mainfrom
ysthakur wants to merge 3 commits intonushell:mainfrom
Conversation
ysthakur
commented
Jun 3, 2025
| @@ -162,38 +162,23 @@ pub fn parse_selection_char(buffer: &str, marker: char) -> ParseResult { | |||
|
|
|||
| /// Finds index for the common string in a list of suggestions | |||
| pub fn find_common_string(values: &[Suggestion]) -> (Option<&Suggestion>, Option<usize>) { | |||
Member
Author
There was a problem hiding this comment.
Side note: I would much rather this returned a single Option<(Suggestion, usize)> (or actually, an Option<&str>/Option<usize> would be even better, since callers can just get the first suggestion themselves). Didn't modify it in this PR because even though this helper's only used in one place in Reedline, consumers of Reedline might be using it for their menus.
ysthakur
added
A-Completions
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when finding a common prefix for partial completions, we assume that suggestions after the first one won't be substrings of the first suggestion. This PR handles that case.
We did have code handling the case when the first suggestion is a substring of a later suggestion, but it doesn't do case-insensitive comparison, so this PR takes care of that too.