feat!: new ReedlineEvent::PartialComplete event#967
Open
blindFS wants to merge 4 commits intonushell:mainfrom
Open
feat!: new ReedlineEvent::PartialComplete event#967blindFS wants to merge 4 commits intonushell:mainfrom
ReedlineEvent::PartialComplete event#967blindFS wants to merge 4 commits intonushell:mainfrom
Conversation
blindFS
commented
Oct 25, 2025
1 task
Contributor
|
Are there tests we can add for this plus the quick complete section that was removed? |
Contributor
Author
That's a good question.
reedline/src/menu/columnar_menu.rs Lines 773 to 795 in 22768f3 |
2 tasks
ysthakur
reviewed
Feb 16, 2026
ReedlineEvent::PartialComplete eventReedlineEvent::PartialComplete event
2d35347 to
0f4948e
Compare
0f4948e to
c55d77c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the partial completion logic from the handling of
ReedlineEvent::MenuNext, so that we can fix nushell/nushell#14152 while keeping the following behavior.Closes #881