Replace call to open by call to platform-specific open#12
Open
nielstron wants to merge 1 commit intonusmodifications:masterfrom
nielstron:fix-open
Open
Replace call to open by call to platform-specific open#12nielstron wants to merge 1 commit intonusmodifications:masterfrom nielstron:fix-open
nielstron wants to merge 1 commit intonusmodifications:masterfrom
nielstron:fix-open
Conversation
taneliang
approved these changes
Nov 30, 2019
Member
taneliang
left a comment
taneliang
left a comment
There was a problem hiding this comment.
Works well on macOS, and I'll test this on Linux later. Did you manage to test this on Windows? It's fine if you aren't
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An alternative to #9 based on findings in #11
Resolves #11