Skip to content

Replace call to open by call to platform-specific open #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace call to open by call to platform-specific open #12

wants to merge 1 commit into from

Conversation

nielstron
Copy link
Contributor

@nielstron nielstron commented Nov 22, 2019 •
edited by taneliang
Loading

An alternative to #9 based on findings in #11

Resolves #11

@taneliang taneliang mentioned this pull request Nov 30, 2019
Closed
taneliang
taneliang approved these changes Nov 30, 2019
View reviewed changes
Copy link
Member

@taneliang taneliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well on macOS, and I'll test this on Linux later. Did you manage to test this on Windows? It's fine if you aren't

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taneliang taneliang taneliang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Opening the downloaded file works only on MacOS
2 participants
@nielstron @taneliang