fix(free days conflict): bug fix in key #4096
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@thejus03 is attempting to deploy a commit to the modsbot's projects Team on Vercel. A member of the Team first needs to authorize it. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4096 +/- ##
==========================================
- Coverage 54.52% 52.88% -1.65%
==========================================
Files 274 287 +13
Lines 6076 6643 +567
Branches 1455 1622 +167
==========================================
+ Hits 3313 3513 +200
- Misses 2763 3130 +367 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Please hold on for a bit. I'm refactoring the optimiser functions into a utils file (#4094), so I've moved and modified the free day conflict function, so it should already be fixed in that version. |
|
sounds good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes #4095
Implementation
Minor bug in changing the key from uniqueKey to displayText for another line too. Previously in #4091 I only updated one line but there was another line that needed to be changed to fix this too.