✨ pulls in changes to main #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…king until previous one is finished (which may have led to failing nodes due to outdated join token)
Co-authored-by: Daniel Lipovetsky <[email protected]>
The API for DescribeEgressOnlyInternetGateways does not support attachment.vpc-id filter. Thus, the call will return all available eigw. Consequences: - CAPA incorrectly selects an unintended eigw for use. Leading to route creation failure since the eigw belongs to a different VPC. - CAPA incorrectly destroys all eigw of all VPCs. This is very catastrophic as it can break other workloads. This commit changes the filter to use cluster tag instead. Additional safeguard is also included to check if the eigw is truly attached the VPC.
* Add RosaRoleConfig API and CRD. * Enable partial reconcile of Rosa Operator Roles * Review fixes * Add integration tests * Add more tests * Fix comments Signed-off-by: serngawy <[email protected]> --------- Signed-off-by: serngawy <[email protected]> Co-authored-by: rknaur <[email protected]>
The overall job timeout in prow is 5h, let's use all of the available time.
🌱 Bump ginkgo timeout
* feat: support setting EKS AuthenticationMode * feat: support setting EKS AuthenticationMode * Update controlplane/eks/api/v1beta2/awsmanagedcontrolplane_webhook_test.go Co-authored-by: Damiano Donati <[email protected]> * add EOF to new files --------- Co-authored-by: Adam Malcontenti-Wilson <[email protected]> Co-authored-by: Damiano Donati <[email protected]>
Update Red Hat documentation links.
🐛 fix: use cluster tag key to list managed egress-only internet gateway
Signed-off-by: serngawy <[email protected]>
Bumps [github.com/go-jose/go-jose/v4](https://github.com/go-jose/go-jose) from 4.0.2 to 4.0.5. - [Release notes](https://github.com/go-jose/go-jose/releases) - [Commits](go-jose/go-jose@v4.0.2...v4.0.5) --- updated-dependencies: - dependency-name: github.com/go-jose/go-jose/v4 dependency-version: 4.0.5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…re for ROSA-HCP (#5464) * RosaNetwork: new CRD & reconciler to provision net infra for ROSA-HCP * ROSANetwork: tests
📖 KEP: adds nodedm proposal
* Support EKS upgrade policy * Apply suggestions from code review Co-authored-by: Damiano Donati <[email protected]> * regenerate * Apply suggestions from code review Co-authored-by: Damiano Donati <[email protected]> * Update pkg/cloud/services/eks/cluster.go Co-authored-by: Damiano Donati <[email protected]> * remove log * Update config/crd/bases/controlplane.cluster.x-k8s.io_awsmanagedcontrolplanes.yaml Co-authored-by: Faiq <[email protected]> * docstring typo * set NotReady if cluster was automatically upgraded * Update pkg/cloud/services/eks/cluster.go Co-authored-by: Faiq <[email protected]> * fix version compare logic * e2e * Apply suggestions from code review Co-authored-by: Damiano Donati <[email protected]> * syntax * WaitForEKSClusterUpgradePolicy fail early on NotFound --------- Co-authored-by: Damiano Donati <[email protected]> Co-authored-by: Faiq <[email protected]>
🌱 Update releasing.md
🌱 Bump cloud build timeout to 2h
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3 to 4. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@v3...v4) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: '4' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
📖 Update ROSA docs
…ithub.com/go-jose/go-jose/v4-4.0.5 🌱 Bump github.com/go-jose/go-jose/v4 from 4.0.2 to 4.0.5
🌱 Log desired AMI architecture and owner ID on errors
…ns/github/codeql-action-4 🌱 Bump github/codeql-action from 3 to 4
✨ Cancel instance refresh on any relevant change to ASG instead of blocking until previous one is finished (which may have led to failing nodes due to outdated join token)
…leARN` field as well
…Template capacity (#5711) * feat: implement auto-population of AWSMachineTemplate capacity and nodeInfo Add AWSMachineTemplateReconciler to automatically populate capacity and node info fields by querying AWS EC2 API. This completes the autoscaling from zero implementation by ensuring the required metadata is available without manual configuration. Changes include: - Add NodeInfo struct with Architecture and OperatingSystem fields to AWSMachineTemplate status - Implement controller that queries EC2 API for instance type specifications - Auto-populate CPU, memory, pods, and ephemeral storage capacity - Auto-detect architecture (amd64/arm64) and OS (linux/windows) from AMI - Add conversion logic for backward compatibility with v1beta1 - Enable status subresource on AWSMachineTemplate CRD - Add comprehensive unit tests (351 lines) covering various scenarios - Add RBAC permissions for controller operations The controller automatically populates these fields when an AWSMachineTemplate is created or updated, eliminating the need for manual configuration and enabling Cluster Autoscaler to make informed scaling decisions from zero nodes. Related: https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/proposals/20210310-opt-in-autoscaling-from-zero.md Squashed from 5 commits: - 9a92a43 Implement autoscaling from zero by auto-populating AWSMachineTemplate capacity - 86fe072 add AWSMachineTemplate NodeInfo - ddaf62c Fix review comments - 4ea52c8 Fix review comments 2 - b398ffc Fix review comments 3 * feat(api): add Conditions field and update for CAPI v1.11 Add Conditions to AWSMachineTemplateStatus and update controller for CAPI v1.11 API changes. Squashed from 2 commits: - ffdf7db Fix review comments 4 - 6493363 rebase #5720
…tomizeconfig 🐛 Remove invalid kustomizeconfig from config/webhook
🐛 Only try to delete AWSMachine bootstrap data for non-machine pool machines
…dates 🐛 Fix lifecycle hooks being updated constantly, consider changes to `RoleARN` field as well
🌱 Deflake ROSA test
skip this field entirely if no files are given
🌱 Bump sigs.k8s.io/cluster-api/test to release-1.11 commit for e2e fixes
…condition Add MachineDeployment and KubeadmControlPlane watchers to trigger AWSMachineTemplate reconciliation, ensuring nodeInfo is populated before cache sync completes. Related: #5711
🌱 e2e: fix AWSMachineTemplate autoscaler test
🌱 e2e: adjust templates to use AWSClusterRoleIdentities per Cluster
…nd e2e test improvements
🌱 autoscaling: try to gather the version information from MachineSets and e2e test improvements
🐛 Fix invalid cloud-config when write_files is nil
This updates the owners and aliases with the latest maintainers. It also performs housekeeping on maintainers and reviewers and removes those that haven't contributed for a while. Signed-off-by: Richard Case <[email protected]>
🌱 chore: update owners and aliases
🌱 github actions: bump to go 1.24
🌱 metadata: prepare main for next release
📖 docs: update releasing.md with steps post-release
🐛 Fix constant re-applying of tags if `AWSMachine.metadata.annotations` is nil
🌱 fix: e2e test: validate inputData during log postprocessing to avoid panic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to main