feat: adds new field for helm values input for cilium CNI #1011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manoj-nutanix
requested review from
dkoshkin,
dlipovetsky,
jimmidyson and
supershal
manoj-nutanix
commented
Jan 16, 2025
jimmidyson
reviewed
Jan 16, 2025
dkoshkin
reviewed
Jan 16, 2025
Contributor
|
can you please update the doc file. https://github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/blob/main/docs/content/addons/cni.md |
supershal
reviewed
Jan 16, 2025
supershal
reviewed
Jan 21, 2025
supershal
reviewed
Jan 21, 2025
supershal
reviewed
Jan 21, 2025
supershal
reviewed
Jan 21, 2025
supershal
reviewed
Jan 21, 2025
supershal
reviewed
Jan 21, 2025
supershal
reviewed
Jan 21, 2025
dkoshkin
approved these changes
Jan 21, 2025
supershal
approved these changes
Jan 22, 2025
Contributor
supershal
left a comment
supershal
left a comment
There was a problem hiding this comment.
The schema looks good to me. Please address other nits and few comments.
manoj-nutanix
force-pushed
the
NCN-105147
branch
from
9392489 to
4ca5455
Compare
supershal
reviewed
Jan 22, 2025
dlipovetsky
reviewed
Jan 22, 2025
supershal
approved these changes
Jan 23, 2025
manoj-nutanix
force-pushed
the
NCN-105147
branch
from
6e9aeb0 to
5453015
Compare
manoj-nutanix
force-pushed
the
NCN-105147
branch
from
5453015 to
c4bbbce
Compare
prajnutanix
approved these changes
Jan 24, 2025
Merged
dkoshkin
added a commit
that referenced
this pull request
Feb 5, 2025
🤖 I have created a release *beep* *boop* --- ## 0.26.0 (2025-02-05) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Exciting New Features 🎉 * feat: adds new field for helm values input for cilium CNI by @manoj-nutanix in #1011 * feat: implementation for user defined configmap for cilium addon in cluster creation by @manoj-nutanix in #1033 * feat: update CAPI to v1.9.3 by @dkoshkin in #1010 * feat: adds cluster's ownerref on cilium helm values source object by @manoj-nutanix in #1034 ### Fixes 🔧 * fix: correctly copy Helm charts in init container by @dkoshkin in #1018 * fix: Use mindthegap v1.17.0 for the helm-repository container by @dlipovetsky in #1024 * fix: use republished COSI controller image by @dkoshkin in #1022 ### Other Changes * test: wait for COSI controller to be ready by @dkoshkin in #1014 * refactor: Remove api module dependency from common module by @jimmidyson in #1019 **Full Changelog**: v0.25.0...v0.26.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dimitri Koshkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
Introduces new field in CAREN API to add custom helm values input for cilium CNI.
Which issue(s) this PR fixes:
Fixes #
https://jira.nutanix.com/browse/NCN-105147
How Has This Been Tested?:
Special notes for your reviewer: