Skip to content

build: Add kube-api-linter #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

build: Add kube-api-linter #1209

wants to merge 6 commits into from

Conversation

jimmidyson
Copy link
Member

Validates upstream API conventions are correctly applied.

@jimmidyson jimmidyson force-pushed the jimmi/kube-api-linter branch 2 times, most recently from d120726 to 677dfa2 Compare July 14, 2025 14:18
@dlipovetsky
Copy link
Contributor

Please consider configuring golangci-lint to run this linter by default, so that the linter runs when we are editing the files, and so that our respective IDE can organize the results (e.g. provide a list of violations that we can navigate). If we're concerned about performance, we can scope the linter to a set of directories.

@jimmidyson jimmidyson force-pushed the jimmi/kube-api-linter branch from 677dfa2 to 7cf3797 Compare July 15, 2025 11:01
@jimmidyson
Copy link
Member Author

@dlipovetsky

Please consider configuring golangci-lint to run this linter by default, so that the linter runs when we are editing the files, and so that our respective IDE can organize the results (e.g. provide a list of violations that we can navigate). If we're concerned about performance, we can scope the linter to a set of directories.

While I really like the idea, I'm having difficulty getting it to play ball...

@jimmidyson jimmidyson force-pushed the jimmi/kube-api-linter branch from b5395d5 to 54d08f3 Compare July 22, 2025 10:05
@jimmidyson
Copy link
Member Author

@dlipovetsky Done! Integrated into make lint and documented how to integrate with vscode (no idea about other IDEs!)

Copy link
Contributor

@dlipovetsky dlipovetsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jimmidyson jimmidyson force-pushed the jimmi/kube-api-linter branch from 90f9c35 to 1cea89a Compare August 19, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants