feat: Skip FD dependent preflight checks when failureDomain configured #1213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlipovetsky
reviewed
Jul 15, 2025
dlipovetsky
reviewed
Jul 15, 2025
faiq
approved these changes
Jul 15, 2025
Contributor
faiq
left a comment
faiq
left a comment
There was a problem hiding this comment.
thanks for adding the tests
Contributor
|
discussed offline w/ Yanhua. It seems storagecontainer is the only preflight check we have to worry about reg. failure domains. If so, we can actually hydrate it w/ the cluster from the failure domain based on #1208. I'll take a stab at this. |
yanhua121
force-pushed
the
jira/NCN-108172
branch
from
2be9a69 to
91ff270
Compare
Contributor
This would be great. We can have a follow-up PR. Let's merge this now. |
dlipovetsky
approved these changes
Jul 15, 2025
Merged
jimmidyson
added a commit
that referenced
this pull request
Jul 23, 2025
🤖 I have created a release *beep* *boop* --- ## 0.32.0 (2025-07-23) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Exciting New Features 🎉 * feat: Validate the configured failure domain(s) exist and valid by @yanhua121 in #1208 * feat: Add context to preflight check messages by @dlipovetsky in #1210 * feat: Skip FD dependent preflight checks when failureDomain configured by @yanhua121 in #1213 * feat(failuredomains): add failure domain rollout controller by @thunderboltsid in #1207 * feat: Add more context to MetalLB config apply conflict errors by @dlipovetsky in #1225 * feat: Add scale from zero cluster-autoscaler support by @jimmidyson in #1227 ### Fixes 🔧 * fix: Fix typo in field name; use one-line strings to prevent future typos by @dlipovetsky in #1206 * fix: Nuanced image Kubernetes version check errors by @dlipovetsky in #1211 * fix(helm): add failuredomain rollout controller config to helm chart by @thunderboltsid in #1214 * fix(ccm): Update Nutanix CCM to v0.5.2 by @thunderboltsid in #1220 * fix(preflight): check storage containers on all failure domains by @thunderboltsid in #1215 * fix(preflight): ensure MDs without overrides are also checked by @thunderboltsid in #1216 * fix: Use JSONPath in check result fields by @dlipovetsky in #1221 * fix: machineDetails fields "cluster" and "subnets" should be optional by @yanhua121 in #1217 * fix(auto-cert-renewal): adds 0 as valid value for daysBeforeExpiry by @atulv7 in #1218 * fix: Namespacesync copies resources after partial copy failure by @dlipovetsky in #1228 ### Other Changes * build: update mindthegap version by @dkoshkin in #1212 ## New Contributors * @atulv7 made their first contribution in #1218 **Full Changelog**: v0.31.1...v0.32.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jimmi Dyson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.nutanix.com/browse/NCN-108172
Ensure all existing preflight checks are also handling failure domains
For 2.16, just to skip the preflight checks that depends on the PE cluster configuration.
Added corresponding unit tests.