feat: Add more context to MetalLB config apply conflict errors #1232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What problem does this PR solve?**: When there is a conflict writing the MetalLB configuration, we want to give more information to the user. **Which issue(s) this PR fixes**: Fixes https://jira.nutanix.com/browse/NCN-107584 **How Has This Been Tested?**: <!-- Please describe the tests that you ran to verify your changes. Provide output from the tests and any manual steps needed to replicate the tests. --> **Special notes for your reviewer**: <!-- Use this to provide any additional information to the reviewers. This may include: - Best way to review the PR. - Where the author wants the most review attention on. - etc. --> --------- Co-authored-by: Jimmi Dyson <[email protected]>
supershal
approved these changes
Jul 23, 2025
dlipovetsky
deleted the
dlipovetsky/more-context-metallb-conflict-v0.27.x
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
Backport of #1225
When there is a conflict writing the MetalLB configuration, we want to give more information to the user.
Which issue(s) this PR fixes:
Fixes https://jira.nutanix.com/browse/NCN-107584
How Has This Been Tested?:
Special notes for your reviewer:
What problem does this PR solve?:
Which issue(s) this PR fixes:
Fixes #
How Has This Been Tested?:
Special notes for your reviewer: