fix: More fixes to preflight result messages and fields #1240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkoshkin
approved these changes
Jul 24, 2025
Contributor
dkoshkin
left a comment
dkoshkin
left a comment
There was a problem hiding this comment.
The changes here look good
prajnutanix
approved these changes
Jul 24, 2025
Merged
jimmidyson
added a commit
that referenced
this pull request
Jul 29, 2025
🤖 I have created a release *beep* *boop* --- ## 0.33.0 (2025-07-28) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Exciting New Features 🎉 * feat: Reserve time to return preflight results before webhook timeout by @dlipovetsky in #1235 * feat: Support context for all Nutanix client calls by @dlipovetsky in #1234 * feat: Support AWS PlacementGroups by @jimmidyson in #1219 ### Fixes 🔧 * fix(webhook): Update cluster webhook to validate failure domains by @thunderboltsid in #1233 * fix: More fixes to preflight result messages and fields by @dlipovetsky in #1240 * fix(deps): udpate CAPX to v1.7.0-beta.5 by @thunderboltsid in #1241 ### Other Changes * build: Use GH client and token for coredns version mapping by @jimmidyson in #1238 * build: Update all tools by @jimmidyson in #1237 **Full Changelog**: v0.32.0...v0.33.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dimitri Koshkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
I identified more mistakes in preflight check messages and fields. The fixes are in separate commits.
Which issue(s) this PR fixes:
Fixes #NCN-108654
How Has This Been Tested?:
Special notes for your reviewer: