refactor: Use metallb APIs instead of unstructured #1317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also refactors the apply logic to return early on anything other than a conflict. Other errors are not necessarily retryable and hence returning early is better practice.
jimmidyson
force-pushed
the
jimmi/metallb-api
branch
from
2e3e52a to
178630c
Compare
dkoshkin
approved these changes
Sep 24, 2025
Contributor
dkoshkin
left a comment
dkoshkin
left a comment
There was a problem hiding this comment.
Thanks for the clear errors on conflicts!
dkoshkin
approved these changes
Sep 25, 2025
dlipovetsky
reviewed
Sep 25, 2025
pkg/handlers/generic/lifecycle/serviceloadbalancer/metallb/configuration.go
Show resolved
Hide resolved
dlipovetsky
reviewed
Sep 25, 2025
pkg/handlers/generic/lifecycle/serviceloadbalancer/metallb/handler.go
Outdated
Show resolved
Hide resolved
dlipovetsky
reviewed
Sep 25, 2025
pkg/handlers/generic/lifecycle/serviceloadbalancer/metallb/handler.go
Outdated
Show resolved
Hide resolved
Contributor
|
Overall, a really nice improvement. Thanks! |
dlipovetsky
approved these changes
Sep 25, 2025
dkoshkin
approved these changes
Sep 26, 2025
Merged
vijayaraghavanr31
pushed a commit
that referenced
this pull request
Oct 8, 2025
Also refactors the apply logic to return early on anything other than a conflict. Other errors are not necessarily retryable and hence returning early is better practice. I decided to do this while I was thinking about introducing the Cilium load-balancer and looking at using vendored Cilium API types instead of unstructured - doing this for metallb was nice and simple. **What problem does this PR solve?**: **Which issue(s) this PR fixes**: Fixes # **How Has This Been Tested?**: <!-- Please describe the tests that you ran to verify your changes. Provide output from the tests and any manual steps needed to replicate the tests. --> **Special notes for your reviewer**: <!-- Use this to provide any additional information to the reviewers. This may include: - Best way to review the PR. - Where the author wants the most review attention on. - etc. -->
This was referenced Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also refactors the apply logic to return early on anything other than a conflict. Other errors are not necessarily retryable and hence returning early is better practice.
I decided to do this while I was thinking about introducing the Cilium load-balancer and looking at using vendored Cilium API types instead of unstructured - doing this for metallb was nice and simple.
What problem does this PR solve?:
Which issue(s) this PR fixes:
Fixes #
How Has This Been Tested?:
Special notes for your reviewer: