fix: Replace empty string as Nutanix image name placeholder value #1353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we update to the next minor release of CAPX (v1.8.x), the empty string we use as the image name placeholder will be invalid. This replaces the empty string with a value that will be valid in CAPX v1.8.x, but is also valid in all previous CAPX versions.
Contributor
Author
|
My mistake--I forgot we get the ClusterClass from the CAPX release. The CAPX release has a valid value:
For that reason, we don't need to patch the ClusterClass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
When we update to the next minor release of CAPX (v1.8.x), the empty string we use as the image name placeholder will be invalid.
This replaces the empty string with a value that will be valid in CAPX v1.8.x, but is also valid in all previous CAPX versions.
Which issue(s) this PR fixes:
Fixes https://jira.nutanix.com/browse/NCN-110262
How Has This Been Tested?:
This change is verified by the Nutanix e2e tests, which use the default ClusterClass this PR modifies.
The
Special notes for your reviewer: