build: handle missing creds Secrets listing CSI images #1359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkoshkin
force-pushed
the
dkoshkin/build-fix-nutanix-csi-image-lister
branch
from
0fe616a to
744a270
Compare
dkoshkin
force-pushed
the
dkoshkin/build-fix-nutanix-csi-image-lister
branch
from
744a270 to
721adcc
Compare
supershal
approved these changes
Oct 22, 2025
Contributor
supershal
left a comment
supershal
left a comment
There was a problem hiding this comment.
Thanks for the quick workaround.
This kind of static validations should be avoided in the chart. Thanks for checking with the CSI team.
prajnutanix
approved these changes
Oct 22, 2025
dkoshkin
added a commit
that referenced
this pull request
Oct 22, 2025
…ges (#1361) **What problem does this PR solve?**: Backport #1359 The CSI bump #1320 introduced this change and broke our automation with: ``` PC secret 'nutanix-csi-credentials' in namespace '' not found when usePC is set to true. Please create the secret before installing or upgrading the chart. ``` This works around it by passing dummy values to the automation. **Which issue(s) this PR fixes**: Fixes # **How Has This Been Tested?**: <!-- Please describe the tests that you ran to verify your changes. Provide output from the tests and any manual steps needed to replicate the tests. --> **Special notes for your reviewer**: <!-- Use this to provide any additional information to the reviewers. This may include: - Best way to review the PR. - Where the author wants the most review attention on. - etc. -->
dkoshkin
added a commit
that referenced
this pull request
Oct 24, 2025
**What problem does this PR solve?**: Follow up to #1341, I forgot to update this automation after changing the template. That PR broke list-images, but now with #1359 there's a preflight that catches these types of errors. **Which issue(s) this PR fixes**: Fixes # **How Has This Been Tested?**: <!-- Please describe the tests that you ran to verify your changes. Provide output from the tests and any manual steps needed to replicate the tests. --> **Special notes for your reviewer**: <!-- Use this to provide any additional information to the reviewers. This may include: - Best way to review the PR. - Where the author wants the most review attention on. - etc. -->
Merged
supershal
added a commit
that referenced
this pull request
Oct 29, 2025
🤖 I have created a release *beep* *boop* --- ## 0.36.0 (2025-10-28) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Exciting New Features 🎉 * feat: update Nutanix CSI to 3.3.8 by @prajnutanix in #1320 * feat: update all addon versions by @dkoshkin in #1352 * feat: deploy AWS Load Balancer controller in EKS clusters by @dkoshkin in #1341 * feat: NFD local feature discovery for aws placement groups by @supershal in #1363 ### Fixes 🔧 * fix: update CAPA to v2.10.0-ncn.1 by @supershal in #1360 * fix: skip syncing controlplane's infrastructure templates for EKS Clusterclass by @supershal in #1366 ### Other Changes * build: handle missing creds Secrets listing CSI images by @dkoshkin in #1359 * build: fix list-images for AWS LB controller by @dkoshkin in #1364 **Full Changelog**: v0.35.1...v0.36.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
The CSI bump #1320 introduced this change and broke our automation with:
This works around it by passing dummy values to the automation.
Which issue(s) this PR fixes:
Fixes #
How Has This Been Tested?:
Special notes for your reviewer: