-
Notifications
You must be signed in to change notification settings - Fork 8
feat: add Multus CNI integration with socket-based readiness #1367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3d1ae5b to
1300f08
Compare
84fa508 to
e633e95
Compare
Implement Multus CNI as an internal addon that automatically deploys alongside primary CNI providers (Cilium/Calico) on supported cloud providers (EKS/Nutanix). - Add socket-based readiness detection using CNI socket paths - Implement template function following CAREN standard pattern - Register Multus handler in lifecycle hooks - Add values template with Go template syntax for socket configuration - Deploy Multus using HelmAddon strategy with readinessIndicatorFile Multus is not exposed in the API and deploys automatically based on cloud provider and CNI selection.
e633e95 to
09b4650
Compare
dkoshkin
requested changes
Oct 30, 2025
charts/cluster-api-runtime-extensions-nutanix/addons/cni/multus/values-template.yaml
Outdated
Show resolved
Hide resolved
charts/cluster-api-runtime-extensions-nutanix/addons/cni/multus/values-template.yaml
Outdated
Show resolved
Hide resolved
9f48fec to
d41520b
Compare
fix: PR comment resolution
d41520b to
afd1f79
Compare
dkoshkin
reviewed
Oct 30, 2025
Contributor
dkoshkin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great, just a few minor comments
charts/cluster-api-runtime-extensions-nutanix/addons/cni/multus/values-template.yaml
Outdated
Show resolved
Hide resolved
ec0fefa to
88711fc
Compare
dkoshkin
approved these changes
Oct 30, 2025
Contributor
dkoshkin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
supershal
reviewed
Oct 31, 2025
supershal
approved these changes
Oct 31, 2025
Merged
vijayaraghavanr31
added a commit
that referenced
this pull request
Nov 4, 2025
🤖 I have created a release *beep* *boop* --- ## 0.37.0 (2025-11-03) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Exciting New Features 🎉 * feat: add Multus CNI integration with socket-based readiness by @legacyrj in #1367 * feat: Add support for deploying K8s Agent as Helm Addon during cluster deployment by @vijayaraghavanr31 in #1345 * feat: Build with go 1.25.3 to fix CVEs by @jimmidyson in #1369 ## New Contributors * @legacyrj made their first contribution in #1367 **Full Changelog**: v0.36.0...v0.37.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
Implement Multus CNI as an internal addon that automatically deploys
alongside primary CNI providers (Cilium/Calico) on supported cloud
providers (EKS/Nutanix).
Multus is not exposed in the API and deploys automatically based on
cloud provider and CNI selection.
Current PR is to deploy by default(i.e always)
Which issue(s) this PR fixes:
Fixes #
How Has This Been Tested?:
Special notes for your reviewer:
Currently it supports both Nutanix and EKS for testing purpose, will remove Nutanix once we finalize handler implementation.