fix: Copy ClusterClass and Templates only if they do not already exist #1386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
When a failure like this happens, does it prevent the rest of the resources from being copied or is this more about fixing the controller from continuously failing? |
It is possible for some resource to exist, but a copy of it cannot be created. For example, CAPX validation became more strict without changing its API version. Templates already on the cluster remain usable. However, they cannot be copied, because the copy does not pass validation. Prior to this change, we always copied the template, and ignored the "already exists" error. Now we first check if the template exist, and only create it if it does not.
dlipovetsky
force-pushed
the
dlipovetsky/namespacesync-get-before-create
branch
from
18c472b to
2359a8c
Compare
Contributor
Author
Good question. The failure does prevent the rest of the resources from being copied. In practice, we have only seen this failure when attempting to copy (a second time) a ClusterClass that is already copied, but that cannot be copied again (due to a backward incompatible change in the CEL validation for the resource). |
dkoshkin
approved these changes
Jan 6, 2026
jimmidyson
approved these changes
Jan 7, 2026
Closed
dlipovetsky
added a commit
that referenced
this pull request
Jan 7, 2026
#1386) **What problem does this PR solve?**: It is possible for some resource to exist, but a copy of it cannot be created. For example, CAPX validation became more strict without changing its API version. Templates already on the cluster remain usable. However, they cannot be copied, because the copy does not pass validation. Prior to this change, we always copied the template, and ignored the "already exists" error. Now we first check if the template exist, and only create it if it does not. **Which issue(s) this PR fixes**: Fixes NCN-110955 **How Has This Been Tested?**: <!-- Please describe the tests that you ran to verify your changes. Provide output from the tests and any manual steps needed to replicate the tests. --> New unit tests exercise the changes. **Special notes for your reviewer**: <!-- Use this to provide any additional information to the reviewers. This may include: - Best way to review the PR. - Where the author wants the most review attention on. - etc. --> (cherry picked from commit 93002a8)
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Merged
kshitij-kumar-ngt
added a commit
that referenced
this pull request
Jan 10, 2026
🤖 I have created a release *beep* *boop* --- ## 0.42.0 (2026-01-08) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Exciting New Features 🎉 * feat: Enable multus installation for Nutanix infra by @kshitij-kumar-ngt in #1445 ### Fixes 🔧 * fix: update CoreDNS mapping file by @dkoshkin in #1447 * fix: Copy ClusterClass and Templates only if they do not already exist by @dlipovetsky in #1386 ## New Contributors * @kshitij-kumar-ngt made their first contribution in #1445 **Full Changelog**: v0.41.3...v0.42.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
It is possible for some resource to exist, but a copy of it cannot be created. For example, CAPX validation became more strict without changing its API version. Templates already on the cluster remain usable. However, they cannot be copied, because the copy does not pass validation.
Prior to this change, we always copied the template, and ignored the "already exists" error. Now we first check if the template exist, and only create it if it does not.
Which issue(s) this PR fixes:
Fixes NCN-110980
How Has This Been Tested?:
New unit tests exercise the changes.
Special notes for your reviewer: