refactor: migration nutanix API to v4 #1444
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m Central version - Replace GetCurrentLoggedInUser() with ValidateCredentials() using Users.List() - Replace V3 GetPrismCentral() with DomainManager.GetPrismCentralVersion() - Remove V3 client dependency from newClient() - Update tests to use new ValidateCredentials interface
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,32 @@ | |||
| package nutanix | |||
Contributor
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
: # github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/pkg/webhook/preflight/nutanix [github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/pkg/webhook/preflight/nutanix.test]
| ValidateCredentialsFunc: func(ctx context.Context) error { | ||
| // Use Users.List() as a lightweight API call to validate credentials. | ||
| // This is available to all users and serves the same purpose as V3's GetCurrentLoggedInUser. | ||
| _, err := convergedc.Users.List(ctx, converged.WithLimit(1)) |
Contributor
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
convergedc.Users undefined (type *"github.com/nutanix-cloud-native/prism-go-client/converged/v4".Client has no field or method Users)
| GetPrismCentralVersionFunc: func(ctx context.Context) (string, error) { | ||
| pcInfo, err := v3c.V3.GetPrismCentral(ctx) | ||
| // Use DomainManager.GetPrismCentralVersion() as V4 equivalent to V3's GetPrismCentral(). | ||
| return convergedc.DomainManager.GetPrismCentralVersion(ctx) |
Contributor
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
convergedc.DomainManager undefined (type *"github.com/nutanix-cloud-native/prism-go-client/converged/v4".Client has no field or method DomainManager) (typecheck)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: migration nutanix API to v4