Open
Conversation
Contributor
|
Great to see this work being started. While working on this please keep the commits tidy so its easier to review. |
- Change import from api/core/v1beta2 to api/core/v1beta1 - Update ClusterVariablesToVariablesMap to accept v1beta1.ClusterVariable - Fix formatting in external API generated file - Part of CAPI 1.12.1 migration BREAKING CHANGE: Function signature changed from v1beta2 to v1beta1.Handlers will be updated in subsequent commits.
- Update builders.go to use v1beta2 (test framework requirement) - Update API structures for CAPI 1.12.1 - Regenerate deepcopy file - Fix external API import path in capa.go - Part of CAPI 1.12.1 migration
- Update controllers to use v1beta2 (Kubernetes CRD version) - Update API structures for CAPI 1.12.1 - Part of CAPI 1.12.1 migration
Contributor
|
HI @maheshnns can you please rebase this PR and fixup the merge conflicts. |
Contributor
|
FYI similar PR #1488 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
https://jira.nutanix.com/browse/NCN-111554