build: Consistently format even generated files #923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmidyson
requested review from
dkoshkin,
dlipovetsky,
supershal and
thunderboltsid
Reworked checks in pre-commit config to check if generated files are consistent after running `make go-generate`, which is called when building the release so we are confident this doesn't get broken in any future PRs. Calling golines when generating deepcopy, etc will ensure a consistent formatting for these generated files. Also reinstated go fix as this is now properly supported in recent go versions. And finally simplify the ignore external call by using golines flag rather than a grep on the go source dirs.
jimmidyson
force-pushed
the
jimmi/fix-generated-formatting
branch
from
7db1811 to
79f5eda
Compare
thunderboltsid
approved these changes
Sep 27, 2024
dkoshkin
approved these changes
Sep 27, 2024
Merged
jimmidyson
added a commit
that referenced
this pull request
Sep 27, 2024
🤖 I have created a release *beep* *boop* --- ## 0.17.0 (2024-09-27) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Exciting New Features 🎉 * feat: Support XValidations (CEL) for CC variables by @jimmidyson in #916 * feat: Update addon versions by @jimmidyson in #917 ### Other Changes * build: Fix up metadata missed in v0.16.0 release process by @jimmidyson in #920 * build: Consistently format even generated files by @jimmidyson in #923 **Full Changelog**: v0.16.0...v0.17.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Daniel Lipovetsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked checks in pre-commit config to check if generated files are
consistent after running
make go-generate, which is called whenbuilding the release so we are confident this doesn't get broken in any
future PRs.
Calling golines when generating deepcopy, etc will ensure a consistent
formatting for these generated files.
Also reinstated go fix as this is now properly supported in recent go versions.
And finally simplify the ignore external call by using golines flag rather than
a grep on the go source dirs.