fix: image registries with no credentials but with a CA #927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkoshkin
force-pushed
the
dkoshkin/fix-registries-with-no-credentials-but-with-ca
branch
from
88f104f to
794b055
Compare
Contributor
Author
|
|
dkoshkin
force-pushed
the
dkoshkin/fix-registries-with-no-credentials-but-with-ca
branch
from
68c0154 to
e3b4e0e
Compare
dkoshkin
force-pushed
the
dkoshkin/fix-registries-with-no-credentials-but-with-ca
branch
from
e3b4e0e to
a7279d4
Compare
jimmidyson
reviewed
Sep 30, 2024
pkg/handlers/generic/mutation/imageregistries/credentials/inject.go
Outdated
Show resolved
Hide resolved
dkoshkin
force-pushed
the
dkoshkin/fix-registries-with-no-credentials-but-with-ca
branch
from
a7279d4 to
890d3f9
Compare
Contributor
Author
|
@jimmidyson PTAL again |
jimmidyson
approved these changes
Nov 7, 2024
dlipovetsky
reviewed
Nov 13, 2024
pkg/handlers/generic/mutation/imageregistries/credentials/credential_provider_config_files.go
Show resolved
Hide resolved
dlipovetsky
approved these changes
Nov 13, 2024
Expect image registries with no credentials but with a CA to still work.
dkoshkin
force-pushed
the
dkoshkin/fix-registries-with-no-credentials-but-with-ca
branch
from
890d3f9 to
5f3677a
Compare
supershal
approved these changes
Nov 13, 2024
jimmidyson
deleted the
dkoshkin/fix-registries-with-no-credentials-but-with-ca
branch
Merged
jimmidyson
added a commit
that referenced
this pull request
Nov 13, 2024
🤖 I have created a release *beep* *boop* --- ## 0.23.0 (2024-11-13) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Exciting New Features 🎉 * feat: Build with go 1.23.3 and upgrade all tools by @jimmidyson in #967 ### Fixes 🔧 * fix: Update mindthegap to fix cert rotation by @dlipovetsky in #971 * fix: image registries with no credentials but with a CA by @dkoshkin in #927 ### Other Changes * build: set helmRepository tag in list-images target by @dkoshkin in #968 * build: rename caren-helm-reg to better match role by @dkoshkin in #969 **Full Changelog**: v0.22.0...v0.23.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
Passing
imageRegistrieswith a CA but without credentials is still a valid configuration and should not error.Which issue(s) this PR fixes:
Fixes #
How Has This Been Tested?:
Special notes for your reviewer: