fix: use minimal image for NFD #941
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The minimal suffix is no longer required as it is just a different tag for backwards compatibility that points to the same image as the default. The default image (without the minimal suffix) is the distroless minimal base image. Details at https://kubernetes-sigs.github.io/node-feature-discovery/v0.13/deployment/image-variants.html |
Contributor
Author
|
Ahh great, thanks for the link! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
This images was reverted (by accident?) in 73b1648#diff-b4f5af9dc43df286d19ee851401e0c36f5e5a1db0e902f8eec24718d93dfce72R1176
Setting the tag in the Helm values to use the minimal image.
Which issue(s) this PR fixes:
Fixes #
How Has This Been Tested?:
Special notes for your reviewer: