Skip to content

build: pass the Chart version when listing images #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2024
Merged

build: pass the Chart version when listing images #945

merged 1 commit into from
Oct 15, 2024

Conversation

@dkoshkin
Copy link
Contributor

@dkoshkin dkoshkin commented Oct 15, 2024

What problem does this PR solve?:
Without this change the script always returned the latest Chart versions, not those defined in the repo

➜  CAREN_VERSION=v0.18.0 make list-images > fixed-images.txt
➜  diff fixed-images.txt caren-images.txt
3c3
< docker.io/rancher/local-path-provisioner:v0.0.27
---
> docker.io/rancher/local-path-provisioner:v0.0.30
8,14c8,14
< public.ecr.aws/ebs-csi-driver/aws-ebs-csi-driver:v1.35.0
< public.ecr.aws/eks-distro/kubernetes-csi/external-attacher:v4.7.0-eks-1-31-3
< public.ecr.aws/eks-distro/kubernetes-csi/external-provisioner:v5.1.0-eks-1-31-3
< public.ecr.aws/eks-distro/kubernetes-csi/external-resizer:v1.12.0-eks-1-31-3
< public.ecr.aws/eks-distro/kubernetes-csi/external-snapshotter/csi-snapshotter:v8.0.1-eks-1-31-3
< public.ecr.aws/eks-distro/kubernetes-csi/livenessprobe:v2.14.0-eks-1-31-3
< public.ecr.aws/eks-distro/kubernetes-csi/node-driver-registrar:v2.12.0-eks-1-31-3
---
> public.ecr.aws/ebs-csi-driver/aws-ebs-csi-driver:v1.36.0
> public.ecr.aws/eks-distro/kubernetes-csi/external-attacher:v4.7.0-eks-1-31-5
> public.ecr.aws/eks-distro/kubernetes-csi/external-provisioner:v5.1.0-eks-1-31-5
> public.ecr.aws/eks-distro/kubernetes-csi/external-resizer:v1.12.0-eks-1-31-5
> public.ecr.aws/eks-distro/kubernetes-csi/external-snapshotter/csi-snapshotter:v8.1.0-eks-1-31-5
> public.ecr.aws/eks-distro/kubernetes-csi/livenessprobe:v2.14.0-eks-1-31-5
> public.ecr.aws/eks-distro/kubernetes-csi/node-driver-registrar:v2.12.0-eks-1-31-5
25,28c25,28
< quay.io/cilium/cilium-envoy:v1.29.9-1726784081-a90146d13b4cd7d168d573396ccf2b3db5a3b047
< quay.io/cilium/cilium:v1.16.2
< quay.io/cilium/hubble-relay:v1.16.2
< quay.io/cilium/operator-generic:v1.16.2
---
> quay.io/cilium/cilium-envoy:v1.29.9-1728346947-0d05e48bfbb8c4737ec40d5781d970a550ed2bbd
> quay.io/cilium/cilium:v1.16.3
> quay.io/cilium/hubble-relay:v1.16.3
> quay.io/cilium/operator-generic:v1.16.3
34c34
< registry.k8s.io/nfd/node-feature-discovery:v0.16.4
---
> registry.k8s.io/nfd/node-feature-discovery:v0.16.5

Which issue(s) this PR fixes:
Fixes #

How Has This Been Tested?:

Special notes for your reviewer:

@dkoshkin dkoshkin requested review from faiq and jimmidyson October 15, 2024 21:14
jimmidyson
jimmidyson approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@jimmidyson jimmidyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh! Thanks for fixing!

@dkoshkin dkoshkin enabled auto-merge (squash) October 15, 2024 21:27
@dkoshkin dkoshkin merged commit 5aad02e into main Oct 15, 2024
22 checks passed
@dkoshkin dkoshkin deleted the dkoshkin/build-pass-chart-version-to-list-images branch October 15, 2024 21:44
@faiq faiq mentioned this pull request Oct 24, 2024
Merged
faiq added a commit that referenced this pull request Oct 24, 2024
@faiq
release(main): v0.19.0 (#948)
c6307ea 
🤖 I have created a release *beep* *boop*
---


## 0.19.0 (2024-10-23)

<!-- Release notes generated using configuration in .github/release.yaml
at main -->

## What's Changed
### Exciting New Features 🎉
* feat: copy charts to pvc by @faiq in
#947
### Other Changes
* build: pass the Chart version when listing images by @dkoshkin in
#945


**Full Changelog**:
v0.18.0...v0.19.0

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jimmidyson jimmidyson jimmidyson approved these changes

@faiq faiq faiq approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dkoshkin @jimmidyson @faiq