Update Nuts node version #385
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the project’s Go toolchain and refreshes module dependencies as part of bumping the nuts-node dependency.
Changes:
- Bump
github.com/nuts-foundation/nuts-nodeto a newer pseudo-version. - Update the Go toolchain version from
1.25.6to1.25.7(including the Docker builder image). - Refresh a broad set of (mostly indirect) dependencies in
go.mod/go.sum(notably OpenTelemetry, DB drivers, and other libs).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Dockerfile | Updates the Go builder base image to golang:1.25.7-alpine. |
| go.mod | Bumps Go version, updates nuts-node, and adjusts direct/indirect dependency versions. |
| go.sum | Updates checksums to match the new module graph after dependency changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| module github.com/nuts-foundation/nuts-knooppunt | ||
|
|
||
| go 1.25.6 | ||
| go 1.25.7 |
There was a problem hiding this comment.
The root module Go version was bumped to 1.25.7, but this repo still has other Go version pins at 1.24.4 (e.g., test/testdata/go.mod and the CI workflow matrix). If the intention is to upgrade the toolchain, update those pins as well (or document/ensure that GOTOOLCHAIN auto-upgrade is relied on), otherwise builds/tests may run under different Go versions depending on entrypoint.
| go 1.25.7 | |
| go 1.24.4 |
| go.opentelemetry.io/otel v1.40.0 | ||
| go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp v0.14.0 | ||
| go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp v1.38.0 | ||
| go.opentelemetry.io/otel/sdk v1.38.0 | ||
| go.opentelemetry.io/otel/sdk/log v0.14.0 |
There was a problem hiding this comment.
OpenTelemetry dependencies are now split across versions: core go.opentelemetry.io/otel is bumped to v1.40.0, but the SDK/exporters are still pinned at v1.38.0 in this file. This kind of version skew within the OTel Go modules can lead to subtle incompatibilities; it would be safer to bump the SDK/exporters (and related contrib modules) to the matching release or keep core at the same version as the SDK/exporters.
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
Co-authored-by: Copilot <[email protected]>
* Initial plan * Align OpenTelemetry SDK and exporters to v1.40.0 Co-authored-by: reinkrul <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: reinkrul <[email protected]>
No description provided.