Fix nested HasOne mutations when related record exists#2742
Merged
Conversation
When using `upsert` on a HasOne relation without providing an ID, the existing implementation always created a fresh model via `$relation->make()`. This caused duplicate records to be created instead of updating the existing related record. Now checks if a record already exists via `$relation->first()` before falling back to creating a new model instance. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Previously, using `create` on a hasOne relation when a related model already exists would silently create a second record, corrupting the relationship. Now throws a GraphQL error guiding users to use `upsert`. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
spawnia
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two issues with nested
HasOnemutations when a related record already exists:upsertwithout ID: Now correctly updates the existing record instead of creating a duplicatecreate: Now throws a clear error instead of silently creating a duplicate recordChanges
upsertfixWhen using
upserton aHasOnerelation without providing anid, the existing record is now found and updated rather than creating a new one.createvalidationWhen using
createon aHasOnerelation where a related record already exists, a descriptive error is thrown:Test plan
testCreateHasOneWhenAlreadyExistsverifying error is throwntestUpdateAndUpsertExistingHasOneWithoutIDcovers upsert fixRelated
🤖 Generated with Claude Code