Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 95169161e0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Updates PHP tooling/style compliance by switching unserialize() calls to the thecodingmachine/safe wrapper and aligning inline PHPDoc formatting, with a small change to authorization exception chaining.
Changes:
- Import
Safe\unserializein several source/test/benchmark files so unserialization failures throw exceptions instead of emitting warnings/returningfalse. - Reformat a couple of parameter/property PHPDoc blocks into single-line doc comments.
- Change
BaseCanDirectiveto rethrow authorization failures with the original throwable attached.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/Unit/Subscriptions/SubscriberTest.php | Use Safe\unserialize in serialization round-trip test. |
| tests/Unit/Schema/AST/DocumentASTTest.php | Use Safe\unserialize in DocumentAST serialization test. |
| tests/Integration/Async/AsyncDirectiveTest.php | Use Safe\unserialize when cycling queued job through serialization. |
| src/Subscriptions/Subscriber.php | Use Safe\unserialize for restoring stored query/context. |
| src/Subscriptions/Storage/RedisStorageManager.php | Use Safe\unserialize when reading subscribers from Redis. |
| src/Execution/ContextSerializer.php | Use Safe\unserialize when restoring serialized GraphQL context. |
| benchmarks/ASTUnserializationBench.php | Use Safe\unserialize in benchmark methods. |
| src/Scout/ScoutEnhancer.php | Collapse constructor param PHPDoc to single line. |
| src/Execution/Arguments/Argument.php | Collapse property PHPDoc to single line. |
| src/Auth/BaseCanDirective.php | Attach original throwable when throwing AuthorizationException for EXCEPTION_NOT_AUTHORIZED. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.