Skip to content

fix: throw error if non-POJO is an error #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: throw error if non-POJO is an error #18

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0aa36c0
fix: throw error if non-POJO is an error
Feb 18, 2022
1a4c270
fix: variable in if-clause
Feb 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,11 @@ export default function devalue (value: any) {
Object.getOwnPropertyNames(proto).sort().join('\0') !== objectProtoOwnPropertyNames
) {
if (typeof thing.toJSON !== 'function') {
if (thing instanceof Error) {
const newMessage = `Cannot stringify error ${thing.constructor.name} since it is non-POJOs. Original error: ${thing.message}`
thing.message = newMessage
throw thing
}
log(`Cannot stringify arbitrary non-POJOs ${thing.constructor.name}`)
}
} else if (Object.getOwnPropertySymbols(thing).length > 0) {
Expand Down