refactor: deepen auth module setup - #335
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
better-auth | 182dac5 | May 01 2026, 07:36 AM |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This deepens the auth module setup path by moving setup policy into a dedicated internal module and leaving
src/module.tsas the orchestration layer. The new seam resolves auth config descriptors, mode flags, provider selection, runtime config decisions, and auth route rules in one pass, which gives later schema and type work a stable place to plug into.The change also pulls the prepare-types and NuxtHub database externalization hooks into dedicated registration helpers, adds template builders for route rules and schema exports, and introduces direct setup-state tests for client-only mode, NuxtHub presence, provider selection, missing config handling, and route-rule extraction.
Checks run:
pnpm exec vitest run test/module-setup.test.ts test/config-paths.test.ts test/runtime-config.test.ts test/database-provider.test.ts,pnpm exec vitest run test/module.test.ts test/no-hub.test.ts,pnpm exec eslint src/module.ts src/module/setup.ts src/module/hooks.ts src/module/templates.ts test/module-setup.test.ts,pnpm typecheck, andpnpm typecheck:runtime-server.