-
-
Notifications
You must be signed in to change notification settings - Fork 743
fix: syntax error with datetime fields and standardize date/datetime formats
#3698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@maximepvrt is attempting to deploy a commit to the Nuxt Team on Vercel. A member of the Team first needs to authorize it. |
📝 WalkthroughWalkthroughAdded two new schema fields to the people collection: Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
|
@Joehoel This PR should resolve the issue, I would appreciate if you can verify using |
Testing fix for datetime fields syntax error. Uses pkg.pr.new build: https://pkg.pr.new/@nuxt/content@3698 Ref: nuxt/content#3698 (comment)
|
@farnabaz If you prefer using an ISO datetime format like I can also look into removing the dependency on |
This PR addresses two separate improvements:
Standardize date/datetime formats
YYYY-MM-DDYYYY-MM-DD HH:mm:ssThese are the default storage formats for dates in databases, ensuring consistent behavior across queries.
I chose to use
@internationalized/date, as in Nuxt UI / Reka, because the nativeDateobject implicitly applies the server timezone when none is specified, which can shiftdatetimevalues.It’s therefore better to let the nuxt application decide whether a date is GMT or timezone-aware, which is why
CalendarDateTimeis more appropriate.