Skip to content

Conversation

Hebilicious
Copy link
Member

@Hebilicious Hebilicious commented Mar 17, 2025

Cloudflare Workers is going to be in the future the main way to deploy application on Cloudflare, presenting it first makes sense. This also includes some re-organizing of the cloudflare pages section.

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Cloudflare Workers is going to be in the future the main way to deploy application on Cloudflare, presenting it first makes sense. This also includes some re-organizing of the cloudflare pages section.
@Hebilicious Hebilicious requested a review from pi0 March 18, 2025 14:07
@pi0
Copy link
Member

pi0 commented Mar 18, 2025

The current config and docs are valid 💯

Thinking would be better advise new users to use the new managed deployConfig feature flag.

export default defineNuxtConfig({
  compatibilityDate: "2025-03-01",
  nitro: { cloudflare: { nodeCompat: true, deployConfig: true } }
});

It generates all proper config (including compat flags and asset binding with valid path).

Cloudflare starter template for Nuxt already updated with this and Nitro docs should be updated as well.

@Hebilicious
Copy link
Member Author

Hebilicious commented Mar 18, 2025

The current config and docs are valid 💯

Thinking would be better advise new users to use the new managed deployConfig feature flag.

export default defineNuxtConfig({
  compatibilityDate: "2025-03-01",
  nitro: { cloudflare: { nodeCompat: true, deployConfig: true } }
});

It generates all proper config (including compat flags and asset binding with valid path).

Cloudflare starter template for Nuxt already updated with this and Nitro docs should be updated as well.

I don't mind making the change, but what is the behaviour of this flag ?
If I'm adding anything custom to my wrangler.jsonc, such as a route or observability, does deployConfig override wrangler.jsonc? Or does it merges some properties with a user provided one?

Should we meet in the middle and recommend in this docs using deployConfig as an alternative to the user controlled wrangler.jsonc ? There's a subset of user that definitely prefer avoiding the abstractions.

@pi0
Copy link
Member

pi0 commented Mar 18, 2025

Yes, it will be merged if the user config exists.

We had been working with the cloudflare team for months to achieve this functionality (that is the default for the ongoing vite plugin and new nitro) -- it is only not enabled today because cloudflare needs safer migration for existing deployments.

@Hebilicious
Copy link
Member Author

@pi0 got it, I made changes to recommend the use of these flags and provided more context.

Copy link

@emily-shen emily-shen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments from the Cloudflare side, thanks so much for putting up this PR 🧡

@Hebilicious Hebilicious requested review from emily-shen and pi0 March 27, 2025 12:52
Copy link

@emily-shen emily-shen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting up this PR! 🧡

@Hebilicious Hebilicious requested a review from atinux as a code owner September 13, 2025 13:32
@Hebilicious
Copy link
Member Author

Hebilicious commented Sep 13, 2025

@pi0 I stumbled back onto this, made some changes to resolve the comments, resolved merge conflicts and added a section on advanced configuration. What do you think ?

It's been open for 6 months now, so please feel free to make necessary changes directly to get this merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants