Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/reproduction-close.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
stale:
runs-on: ubuntu-latest
steps:
- uses: actions/stale@3a9db7e6a41a89f618792c92c0e97cc736e1b13f # v10.0.0
- uses: actions/stale@997185467fa4f803885201cee163a9f38240193d # v10.1.1
with:
days-before-stale: -1 # Issues and PR will never be flagged stale automatically.
stale-issue-label: needs reproduction # Label that flags an issue as stale.
Expand Down
2 changes: 1 addition & 1 deletion docs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"@nuxt/fonts": "^0.12.1",
"@nuxt/image": "^2.0.0",
"@nuxt/scripts": "workspace:*",
"@nuxt/ui": "4.0.0",
"@nuxt/ui": "4.3.0",
"@nuxthq/studio": "^2.2.1",
"@nuxtjs/seo": "^3.3.0",
"@vueuse/core": "^14.1.0",
Expand Down
20 changes: 10 additions & 10 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,9 @@
"@stripe/stripe-js": "^7.0.0 || ^8.0.0",
"@types/google.maps": "^3.58.1",
"@types/vimeo__player": "^2.18.3",
"@types/youtube": "^0.1.0",
"@unhead/vue": "^2.0.3",
"posthog-js": "^1.0.0"
"@types/youtube": "^0.1.2",
"@unhead/vue": "^2.1.2",
"posthog-js": "^1.321.2"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"posthog-js": "^1.321.2"
"posthog-js": "^1.0.0"

The posthog-js peer dependency constraint changed from ^1.0.0 to ^1.321.2, which is unusually restrictive and appears unintentional given the patch version bump in devDependencies (1.321.1 → 1.321.2).

View Details

Analysis

Overly restrictive posthog-js peer dependency breaks backward compatibility

What fails: The posthog-js peer dependency constraint in package.json was changed from ^1.0.0 to ^1.321.2 (commit 1536ad2), restricting supported versions to 1.321.2+ and rejecting all prior versions (1.0.0-1.321.1) that would previously install.

How to reproduce:

# User has posthog-js 1.200.0 installed (legitimate version under old ^1.0.0 constraint)
npm install @nuxt/scripts
# After update, npm now rejects this version because 1.200.0 does not satisfy ^1.321.2

Result: npm/pnpm install fails with: "[email protected] not satisfied by ^1.321.2"

Expected: The peer dependency should remain at ^1.0.0 (or similar permissive constraint) since:

  • Code only uses posthog.init() and basic config options (api_host, capture_pageview, disable_session_recording) available since 1.0.0
  • The devDependency update was only a patch bump (1.222.0 → 1.321.2), not a major version requiring API changes
  • Peer dependencies should be permissive to maximize compatibility
  • Semantic versioning guidance indicates patch/minor version updates within the same major version should be backward compatible

This change appears to be an error from automated dependency update tooling (Renovate) that applied the same pinpoint version to both devDependencies and peerDependencies.

},
"peerDependenciesMeta": {
"@googlemaps/markerclusterer": {
Expand Down Expand Up @@ -110,17 +110,17 @@
"@vueuse/core": "^14.1.0",
"consola": "^3.4.2",
"defu": "^6.1.4",
"h3": "^1.15.4",
"h3": "^1.15.5",
"magic-string": "^0.30.21",
"ofetch": "^1.5.1",
"ohash": "^2.0.11",
"pathe": "^2.0.3",
"pkg-types": "^2.3.0",
"sirv": "^3.0.2",
"std-env": "^3.10.0",
"ufo": "^1.6.2",
"ufo": "^1.6.3",
"unplugin": "^2.3.11",
"unstorage": "^1.17.3",
"unstorage": "^1.17.4",
"valibot": "^1.2.0"
},
"devDependencies": {
Expand All @@ -129,9 +129,9 @@
"@nuxt/eslint-config": "^1.12.1",
"@nuxt/module-builder": "^1.0.2",
"@nuxt/scripts": "workspace:*",
"@nuxt/test-utils": "3.19.2",
"@paypal/paypal-js": "^9.1.0",
"posthog-js": "^1.222.0",
"@nuxt/test-utils": "3.23.0",
"@paypal/paypal-js": "^9.2.0",
"posthog-js": "^1.321.2",
"@types/semver": "^7.7.1",
"@typescript-eslint/typescript-estree": "^8.53.0",
"@vue/test-utils": "^2.4.6",
Expand All @@ -140,7 +140,7 @@
"changelogen": "^0.6.2",
"eslint": "^9.39.2",
"eslint-plugin-n": "^17.23.2",
"happy-dom": "^20.1.0",
"happy-dom": "^20.3.0",
"knitwork": "^1.3.0",
"nuxt": "^4.2.2",
"playwright-core": "^1.57.0",
Expand Down
Loading
Loading