feat: support disabling router integrations #5213
Open
+560
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Supersedes #4763
Closes #4233
Related to #4341
❓ Type of change
📚 Description
This pull request is a follow-up to #4763, intended for v4.
This is an attempt at allowing the use of Nuxt UI in frameworks that don't require
vue-router. This is the case in Inertia applications (even if Inertia currently has its own exception built in Nuxt UI), in Hybridly applications, in SPAs without routing, etc.I took the same approach as the Inertia override: if the new
routeroption is set tofalse, it will load stubs withoutvue-router.Note that I also deprecated the previous
inertiaoption, in favor ofrouter: 'inertia'. This felt like the proper thing to do, but I kept theinertiaoption working.I tested this PR in a fresh Hybridly app, and it works well, except for the links (obviously) which use anchor tags in those apps.
This is an acceptable workaround for now, but I think Nuxt UI should allow for userland override of components, instead of offering framework-specific components—because there are other frameworks that might have dedicated link components (eg. we plan to have that at Tempest).
If this is not the route you want to go and you prefer maintaining those frameworks' link components, I will follow-up this PR for a Hybridly one.
cc @benjamincanac as stated in the previous PR, I wasn't sure what was wrong with this approach, so a review from you would be welcome