Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the solution to target .NET 8 and C# 12 by updating the build configuration and the related dependency references, and it documents the breaking changes introduced with the update.
- Updated DotNetVersion, UnoCheck_Version, and UnoCheck_Manifest in the build/stage-build.yml file.
- Added a new breaking changes entry in BREAKING_CHANGES.md to reflect support for .NET 8 and removal of .NET 7.
Reviewed Changes
Copilot reviewed 2 out of 12 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| build/stage-build.yml | Updated the .NET version and dependency values for CI builds. |
| BREAKING_CHANGES.md | Documented the breaking changes regarding .NET version support. |
Files not reviewed (10)
- src/Navigation.Tests/Navigation.Tests.csproj: Language not supported
- src/SectionsNavigation.Abstractions/SectionsNavigation.Abstractions.csproj: Language not supported
- src/SectionsNavigation.Reactive/SectionsNavigation.Reactive.csproj: Language not supported
- src/SectionsNavigation.Uno.WinUI/SectionsNavigation.Uno.WinUI.csproj: Language not supported
- src/SectionsNavigation.Uno.WinUI/winappsdk-workaround.targets: Language not supported
- src/SectionsNavigation/SectionsNavigation.csproj: Language not supported
- src/StackNavigation.Abstractions/StackNavigation.Abstractions.csproj: Language not supported
- src/StackNavigation.Reactive/StackNavigation.Reactive.csproj: Language not supported
- src/StackNavigation.Uno.WinUI/StackNavigation.Uno.WinUI.csproj: Language not supported
- src/StackNavigation/StackNavigation.csproj: Language not supported
10c5da0 to
ec0a7fc
Compare
juliecantin
approved these changes
Apr 2, 2025
carlh98
reviewed
Apr 2, 2025
src/SectionsNavigation.Abstractions/SectionsNavigation.Abstractions.csproj
Outdated
Show resolved
Hide resolved
carlh98
reviewed
Apr 2, 2025
src/SectionsNavigation.Reactive/SectionsNavigation.Reactive.csproj
Outdated
Show resolved
Hide resolved
Lee31416
approved these changes
Apr 2, 2025
jeanplevesque
approved these changes
Apr 2, 2025
d983561 to
6318a35
Compare
carlh98
approved these changes
Apr 2, 2025
a605515 to
816ce07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Issue: #
Proposed Changes
What is the current behavior?
Projects in the solution target .NET 6-7 and C# 10-11.
What is the new behavior?
Projects in the solution target .NET 8 and C# 12.
Impact on version
buildfolder was changed..githubfolder was changed.Checklist
Please check that your PR fulfills the following requirements:
Other information