Skip to content

fix: navigation animation issue#64

Merged
Marc-Antoine-Soucy merged 1 commit intomainfrom
dev/maso/animationbug
Jan 15, 2026
Merged

fix: navigation animation issue#64
Marc-Antoine-Soucy merged 1 commit intomainfrom
dev/maso/animationbug

Conversation

@Marc-Antoine-Soucy
Copy link
Contributor

GitHub Issue: #

unoplatform/uno#22375

Proposed Changes

  • Bug fix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other, please describe:

What is the current behavior?

When doing some navigations, sometimes, the page remains blank when returning to it because the opacity of the page remains 0.

What is the new behavior?

The new workaround ensures the opacity always returns to 1.

Impact on version

  • Major (Public API was modified.)
    • Public constructs (class, struct, delegate, enum, etc.) were removed or renamed.
    • Public members were removed or renamed.
    • Public method signatures were changed or renamed.
  • Minor (Public API was extended.)
    • Public constructs, members, or overloads were added.
  • Patch (Public API was unchanged.)
    • A bug in behavior was fixed.
    • Documentation was changed.
  • None (The library is unchanged.)
    • Only code under the build folder was changed.
    • Only code under the .github folder was changed.

Checklist

Please check that your PR fulfills the following requirements:

  • Documentation has been added/updated.
  • Automated Unit / Integration tests for the changes have been added/updated.
  • Updated BREAKING_CHANGES.md (if you introduced a breaking change).
  • Your conventional commits are aligned with the Impact on version section.

Other information

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a navigation animation bug where pages could remain blank after navigation on iOS and Android platforms due to the opacity property remaining at 0. The fix replaces a workaround that explicitly set opacity values with animation precedence with a cleaner approach that clears the opacity property before setting it.

Changes:

  • Replaced SetValue with animation precedence workaround with ClearValue approach for iOS and Android
  • Updated comments to reference the GitHub issue instead of a TODO
  • Reordered operations to call ClearValue before setting Opacity property
Comments suppressed due to low confidence (3)

src/SectionsShared/Animations.cs:82

  • The SlideFrame2UpwardsToHideFrame1 method also sets frame2.Opacity = 1 but does not include the same ClearValue workaround applied to the fade methods. If the opacity issue affects fade animations on iOS/Android, it might also affect slide animations. Consider applying the same fix pattern (ClearValue before setting Opacity) for consistency and to prevent similar issues.
			frame2.Opacity = 1;

src/SectionsShared/Animations.cs:98

  • The SlideFrame1DownToRevealFrame2 method also sets frame2.Opacity = 1 but does not include the same ClearValue workaround applied to the fade methods. For consistency and to prevent similar opacity-related issues, consider applying the same fix pattern (ClearValue before setting Opacity).
			frame2.Opacity = 1;

src/SectionsShared/Animations.cs:117

  • The CollapseFrame1AndShowFrame2 method also sets frame2.Opacity = 1 but does not include the same ClearValue workaround applied to the fade methods. For consistency and to prevent similar opacity-related issues, consider applying the same fix pattern (ClearValue before setting Opacity).
			frame2.Opacity = 1;

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Marc-Antoine-Soucy Marc-Antoine-Soucy merged commit 926f58d into main Jan 15, 2026
9 checks passed
@Marc-Antoine-Soucy Marc-Antoine-Soucy deleted the dev/maso/animationbug branch January 15, 2026 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants