fix: navigation animation issue#64
Merged
Marc-Antoine-Soucy merged 1 commit intomainfrom Jan 15, 2026
Merged
Conversation
Soap-141
approved these changes
Jan 15, 2026
There was a problem hiding this comment.
Pull request overview
This PR fixes a navigation animation bug where pages could remain blank after navigation on iOS and Android platforms due to the opacity property remaining at 0. The fix replaces a workaround that explicitly set opacity values with animation precedence with a cleaner approach that clears the opacity property before setting it.
Changes:
- Replaced
SetValuewith animation precedence workaround withClearValueapproach for iOS and Android - Updated comments to reference the GitHub issue instead of a TODO
- Reordered operations to call
ClearValuebefore settingOpacityproperty
Comments suppressed due to low confidence (3)
src/SectionsShared/Animations.cs:82
- The
SlideFrame2UpwardsToHideFrame1method also setsframe2.Opacity = 1but does not include the sameClearValueworkaround applied to the fade methods. If the opacity issue affects fade animations on iOS/Android, it might also affect slide animations. Consider applying the same fix pattern (ClearValue before setting Opacity) for consistency and to prevent similar issues.
frame2.Opacity = 1;
src/SectionsShared/Animations.cs:98
- The
SlideFrame1DownToRevealFrame2method also setsframe2.Opacity = 1but does not include the sameClearValueworkaround applied to the fade methods. For consistency and to prevent similar opacity-related issues, consider applying the same fix pattern (ClearValue before setting Opacity).
frame2.Opacity = 1;
src/SectionsShared/Animations.cs:117
- The
CollapseFrame1AndShowFrame2method also setsframe2.Opacity = 1but does not include the sameClearValueworkaround applied to the fade methods. For consistency and to prevent similar opacity-related issues, consider applying the same fix pattern (ClearValue before setting Opacity).
frame2.Opacity = 1;
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jeanplevesque
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Issue: #
unoplatform/uno#22375
Proposed Changes
What is the current behavior?
When doing some navigations, sometimes, the page remains blank when returning to it because the opacity of the page remains 0.
What is the new behavior?
The new workaround ensures the opacity always returns to 1.
Impact on version
buildfolder was changed..githubfolder was changed.Checklist
Please check that your PR fulfills the following requirements:
Other information