Initial Version by Soap-141 · Pull Request #1 · nventive/DeviceCore

Soap-141 · 2025-07-13T19:58:38Z

GitHub Issue: #

Proposed Changes

What is the current behavior?

Empty repository.

What is the new behavior?

Added documentation, CI/CD, and some features.

Checklist

Please check that your PR fulfills the following requirements:

Documentation has been added/updated.
~~Automated tests for the changes have been added/updated.~~
Updated BREAKING_CHANGES.md (if you introduced a breaking change).

Other information

Copilot

Pull Request Overview

This PR initializes a new DeviceCore library for cross-platform device functionality on Uno/WinUI applications. The PR adds comprehensive device service abstractions and implementations for Android, iOS, and Windows platforms.

Establishes foundational library structure with abstractions and platform-specific implementations
Implements core device services including accelerometer, ambient light, battery information, flashlight, and screen wake lock
Sets up CI/CD pipeline with Azure DevOps and comprehensive build configuration

Reviewed Changes

Copilot reviewed 31 out of 31 changed files in this pull request and generated 13 comments.

Show a summary per file

File	Description
DeviceCore.sln	Solution structure defining library projects and build configuration
src/lib/DeviceCore.Abstractions/	Core abstractions and interfaces for device services with fake implementations for testing
src/lib/DeviceCore.Uno.WinUI/	Platform-specific implementations using Uno framework for Android/iOS/Windows
build/	Complete CI/CD pipeline configuration with Azure DevOps, GitVersion, and NuGet publishing
README.md	Comprehensive documentation covering setup, usage examples, and platform-specific requirements

src/lib/DeviceCore.Abstractions/BatteryInformation/PowerSupplyStatus.cs

src/lib/DeviceCore.Uno.WinUI/BatteryInformation/EnergySaverStatus.Extensions.cs

src/lib/DeviceCore.Abstractions/AmbientLight/AmbiantLightReading.cs

src/lib/DeviceCore.Abstractions/AmbientLight/IAmbientLightProvider.cs

src/lib/DeviceCore.Abstractions/AmbientLight/FakeAmbientLightProvider.cs

src/lib/DeviceCore.Uno.WinUI/AmbientLightProvider.cs

src/lib/DeviceCore.Abstractions/BatteryInformation/FakeBatteryInformationProvider.cs

src/lib/DeviceCore.Abstractions/Accelerometer/AccelerometerReading.cs

src/lib/DeviceCore.Uno.WinUI/ScreenWakeLockService.cs

README.md

src/lib/DeviceCore.Abstractions/DeviceCore.Abstractions.csproj

jeanplevesque · 2026-01-13T13:51:15Z

src/lib/DeviceCore.Abstractions/Accelerometer/IAccelerometerService.cs

+	/// <summary>
+	/// Gets or sets the current report interval for the accelerometer.
+	/// </summary>
+	uint ReportInterval { get; set; }


What's the unit?

jeanplevesque · 2026-01-13T13:52:17Z

src/lib/DeviceCore.Abstractions/Accelerometer/AccelerometerReading.cs

+	/// Gets the performance count associated with the reading.
+	/// This allows the reading to be synchronized with other devices and processes on the system.
+	/// </summary>
+	public TimeSpan? PerformanceCount { get; }


I don't understand this property. It's named like count (so some kind of integer?) but it's a nullable TimeSpan and it's not clear what the value means.

jeanplevesque · 2026-01-13T13:54:28Z

src/lib/DeviceCore.Abstractions/AmbientLight/AmbientLightReading.cs

+	/// <summary>
+	/// Gets the performance count associated with the reading.This allows the reading to be synchronized with other devices and processes on the system.
+	/// </summary>
+	public TimeSpan? PerformanceCount { get; }


Same here, what does it mean?

jeanplevesque · 2026-01-13T13:56:17Z

src/lib/DeviceCore.Abstractions/BatteryInformation/IBatteryInformationProvider.cs

+	/// <summary>
+	/// Gets the total percentage of charge remaining from all batteries connected to the device.
+	/// </summary>
+	int RemainingChargePercent { get; }


I would expect a percentage to be a value between 0.0 and 1.0 but this is an int. Does it mean that the value is between 0 and 100?

jeanplevesque · 2026-01-13T14:00:12Z

src/lib/DeviceCore.Abstractions/IFlashlightService.cs

+	/// Gets or sets the brightness of the flashlight with a value in the [0.0, 1.0] range.
+	/// </summary>
+	/// <remarks>
+	/// On Android, flashlight brightness cannot be controlled, hence any non-zero BrightnessLevel results in the full brightness of the flashlight.


You mention BrightnessLevel but the property name is Brightness. Are you referring to something else?

jeanplevesque · 2026-01-13T14:03:00Z

src/lib/DeviceCore.Abstractions/IFlashlightService.cs

+	/// <remarks>
+	/// You must set the <see cref="Brightness"/> property before or after calling this method to ensure the desired brightness level is applied when the flashlight is turned on.
+	/// </remarks>
+	void Toggle();


How do we know if we turn it on or off? Why not have a TurnOn(float brightness) and TurnOff methods?

It's also weird that you have to set the brightness before turning on... It means that if the light is already on, it cannot be adjusted? If that's the case, it might not be worth having a setter on the Brightness property.

jeanplevesque · 2026-01-13T14:08:10Z

src/lib/DeviceCore.Abstractions/DeviceCore.Abstractions.csproj

+	</ItemGroup>
+
+	<ItemGroup>
+		<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="10.0.1" />


Do you actually need Logging.Abstractions here?

jeanplevesque · 2026-01-13T14:18:17Z

src/lib/DeviceCore.Uno.WinUI/DeviceCore.Uno.WinUI.csproj

+		<Company>nventive</Company>
+		<AssemblyName>DeviceCore.Uno.WinUI</AssemblyName>
+		<PackageId>DeviceCore.Uno.WinUI</PackageId>
+		<Description>Provides cross-platform device APIs for Uno Platform and WinUI, supporting .NET 8, Android, iOS, and Windows targets.</Description>


You support .NET 10, not 8.

jeanplevesque · 2026-01-13T14:21:34Z

DeviceCore.sln

@@ -0,0 +1,67 @@
+


Now that Visual Studio 2026 is out, you could update this to the new format.

jeanplevesque · 2026-01-13T14:40:45Z

src/lib/DeviceCore.Fakes/FakeAccelerometerService.cs

+/// <summary>
+/// The fake implementation of <see cref="IAccelerometerService"/> for testing purposes.
+/// </summary>
+public sealed class FakeAccelerometerService : IAccelerometerService


What's the vision/strategy for the fake implementations? Right now it seems like a bare minimum implementation that doesn't mimic the real thing. In this one, the observable sequences complete after 1 value, which is likely not the case with the real implementation. Also the ReportInterval property is not even used.

Soap-141 force-pushed the dev/thla/initial-version branch 3 times, most recently from cad6c41 to 596c442 Compare July 19, 2025 16:47

Soap-141 self-assigned this Jul 19, 2025

Soap-141 changed the title ~~Dev/thla/initial version~~ Initial Version Jul 19, 2025

Soap-141 marked this pull request as ready for review August 1, 2025 12:05

ci: Add Azure Pipeline

ae0b01c

Soap-141 force-pushed the dev/thla/initial-version branch from 596c442 to f585753 Compare August 1, 2025 12:17

Soap-141 requested review from Copilot and jeanplevesque August 1, 2025 12:20

Copilot AI reviewed Aug 1, 2025

View reviewed changes

Soap-141 force-pushed the dev/thla/initial-version branch from f585753 to e5d4f3d Compare August 1, 2025 12:30

jeanplevesque reviewed Aug 1, 2025

View reviewed changes

README.md Outdated Show resolved Hide resolved

Soap-141 force-pushed the dev/thla/initial-version branch from e5d4f3d to 5213d30 Compare August 1, 2025 12:48

jeanplevesque reviewed Aug 1, 2025

View reviewed changes

src/lib/DeviceCore.Abstractions/DeviceCore.Abstractions.csproj Outdated Show resolved Hide resolved

Soap-141 force-pushed the dev/thla/initial-version branch from 5213d30 to 8ee0f55 Compare August 1, 2025 12:57

Soap-141 requested a review from jeanplevesque August 1, 2025 12:57

Soap-141 force-pushed the dev/thla/initial-version branch 2 times, most recently from 493a4ce to f105cf8 Compare August 1, 2025 13:34

Soap-141 requested review from Lee31416 and Marc-Antoine-Soucy January 7, 2026 15:28

Soap-141 force-pushed the dev/thla/initial-version branch 2 times, most recently from bee174c to 94766c9 Compare January 7, 2026 16:18

feat: Add platform services

fe0e055

Soap-141 force-pushed the dev/thla/initial-version branch from 94766c9 to fe0e055 Compare January 7, 2026 16:18

Soap-141 requested a review from MatFillion January 7, 2026 18:00

jeanplevesque reviewed Jan 13, 2026

View reviewed changes

Conversation

Soap-141 commented Jul 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Changes

What is the current behavior?

What is the new behavior?

Checklist

Other information

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Soap-141 commented Jul 13, 2025 •

edited

Loading