feat(281249): improve Login and Create Account page reader support#313
Open
Arieldelossantos wants to merge 1 commit intofeature/screen-reader-supportfrom
Open
feat(281249): improve Login and Create Account page reader support#313Arieldelossantos wants to merge 1 commit intofeature/screen-reader-supportfrom
Arieldelossantos wants to merge 1 commit intofeature/screen-reader-supportfrom
Conversation
carlh98
reviewed
May 15, 2023
src/app/ApplicationTemplate.Shared.Views/Styles/Controls/CheckBox.xaml
Outdated
Show resolved
Hide resolved
carlh98
reviewed
May 15, 2023
...app/ApplicationTemplate.Presentation/ViewModels/Authentication/CreateAccountPageViewModel.cs
Outdated
Show resolved
Hide resolved
carlh98
reviewed
May 15, 2023
src/app/ApplicationTemplate.Shared.Views/Styles/Controls/DataValidationView.xaml
Outdated
Show resolved
Hide resolved
Contributor
|
@Arieldelossantos merge latest main to fix your pipeline |
Soap-141
approved these changes
May 16, 2023
Contributor
Soap-141
left a comment
Soap-141
left a comment
There was a problem hiding this comment.
Looks good, just need to fix comments. So if I understand the goal of this Pull Request is to make the choices compatible with a reader?
Soap-141
approved these changes
May 16, 2023
src/app/ApplicationTemplate.Shared.Views/Content/Authentication/CreateAccountPage.xaml
Outdated
Show resolved
Hide resolved
jeanplevesque
requested changes
May 16, 2023
src/app/ApplicationTemplate.Shared.Views/Content/Authentication/CreateAccountPage.xaml
Show resolved
Hide resolved
src/app/ApplicationTemplate.Shared.Views/Content/Authentication/CreateAccountPage.xaml
Outdated
Show resolved
Hide resolved
Contributor
Author
with the accessibility voiceover |
Arieldelossantos
force-pushed
the
dev/arde/improve-login-page
branch
2 times, most recently
from
8149db7 to
cf1119b
Compare
Soap-141
reviewed
May 16, 2023
...icationTemplate.Shared.Views/Converters/FromDataValidationStateToVoiceOverStringConverter.cs
Outdated
Show resolved
Hide resolved
...icationTemplate.Shared.Views/Converters/FromDataValidationStateToVoiceOverStringConverter.cs
Outdated
Show resolved
Hide resolved
Arieldelossantos
force-pushed
the
dev/arde/improve-login-page
branch
from
cf1119b to
7938e50
Compare
Arieldelossantos
force-pushed
the
dev/arde/improve-login-page
branch
from
7938e50 to
f277f99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
Description
improve Login and Create Account page reader support
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Product Backlog Item 281249: Improve screen reader support in UnoAppTemplate
Internal Issue (If applicable):