Soft fork and merge non-controversial fixes and improvments #1627
Conversation
Guide users towards lazy's `init` key for plugins written in VimScript.
Add lua_ls annotations for improved hover experience and replace vim.fn.empty() with vim.tbl_isempty()
The following lines do nothing and can be removed:
format = function(diagnostic)
local diagnostic_message = {
[vim.diagnostic.severity.ERROR] = diagnostic.message,
[vim.diagnostic.severity.WARN] = diagnostic.message,
[vim.diagnostic.severity.INFO] = diagnostic.message,
[vim.diagnostic.severity.HINT] = diagnostic.message,
}
return diagnostic_message[diagnostic.severity]
end,
The following line causes diagnostics which aren't of severity level
error to not have the specific text area underlined. This is less useful
than the default of showing underlines for all diagnostic levels, so
remove this line as well:
underline = { severity = vim.diagnostic.severity.ERROR },
This would allow to write more concise and easy to understands keybinds in the following commit
This could help beginners to get autocompletion, catch mistakes earlier, and allow them to skip the docs for simple configs. This is not perfect because a lot of the plugins type all of their keys as required, even though they have defaults, but this is good enough.
fix: Load guess-indent.nvim
feat(diagnostics): Add `virtual_lines` for discoverability
feat(grep-string): works with visual selection too
fix(diagnostic): remove unnecessary config lines
feat: add toggle to show/hide diagnostics
Feat/0.11 lsp
Add type hints to plugin options where possible
Feature/collapse functions
feat: Enhances breakpoint editing The keymapping `<leader>B` is now configured to guide users through the process of adding a `condition`, `hitCondition`, and `logMessage` to a breakpoint. --------- Co-authored-by: Brian Lehrer <[email protected]>
docs: Add documentation for lazy's `init` key
docs: Document methods to get the latest neovim
|
Also @dam9000 , I'm actually using a fork of your modular kickstart, so let me know if you would like me to also adapt those changes to your fork :D |
|
@oriori1703 personally I don't need that but don't let me stop you if you wish to. |
|
@oriori1703 Sounds good, guess I'll be switching to your fork soon. Using @dam9000 's modular too. |
|
I now also merged these changes to dam9000's modular kickstart. |
|
nice one, i also used your pr for snacks and made an optional addon for nvim kickstart modular, but it would actually be better to do this here, but i never gotten around to it dam9000#74 (ps, why are you not a maintainer for this repo yet, lol) |
Why haven't you forked this repo a year ago and made your fork more popular than the main repo? ;-) lol ;-) You should be thankful for devs that do stuff for free for other devs instead of criticizing them for "not doing enough". ;-) |
I don't know how you got the idea that I was telling anyone they were not doing enough? (I'm a contributer to this repo btw, so actually did just that, I forked it and contributed to it) If you're referring to my "ps, why are you not a maintainer for this repo yet, lol": this was a tongue in cheek way to acknowledge the work @oriori1703 does. Let's focus on the issue ok. You can read here why I'm struggling to wrap my head around this: #1481 (comment) |
|
maybe you like this one as well: |
…ained-upstream Raise the minimum nvim version to 0.11
Very strange, I'll have to send this to upstream EDIT: It's already known, see nvim-lua#1627 nvim-lua#1532
|
Hiya @oriori1703 - just want to clarify. Nobody in particular "caused" burn out. My problem here is that this repo is in a constant state of push/pull with folks wanting new shiny and others being VERY VEHEMENTLY opposed to said shiny :) I'd be happy to merge these changes if someone else in the community approves them. I've read through and they all look reasonable but I don't have time to test them all as I don't use kickstart anymore (And you don't either! I think this repo should be retired, personally.) As to adding maintainers: I'd LOVE to. I'd be happy to hand over the keys to someone else, but thst's not in my power. I'm just a contributor with merge rights, not a repo owner. You'll need to get one of them to notice you and add you as a maintainer. So, to recap:
|
Isn't that the whole point of the repo? You only use it once in its preconfigured state, and then morph it. Although, I do feel like I'm a continuation to that pages-long discussion under the snacks PR. |
|
@tjdevries can you add someone else as a maintainer when @feoh doesnt want to continue anymore? @oriori1703 would be nice :) |
|
It's nice to ever so often check in on the repo to see if there are new plugins, or new native neovim improvements available It was great to just be able to grab the snacks picker config, or the new lsp-config implementation when i finally got around to building my config.. I wonder if a similar model to how ghostty handles issues and prs wont help to get rid of a bit of the noise? i.e. only discussions are open for the peanut gallery, and then contributors with elevated rights can decide if the dicussion warrants an issue/pr? |
|
I would like that very much. But right now we only have feoh as a maintainer, but he doesn't see the point of this repo anymore. So we are essentially stuck unmaintained. |
|
Thank you @dam9000 @oriori1703 for the updates |
There hasn't been any real maintainer activity since the middle of May. This seem to coincide with a comment from @feoh on my PR.
I feel kinda bad for possibly causing the burnout of the only active maintainer of kickstart with my PR , so I decided to try ease the maintenance burned by reviewing most of the open PRs and merging them to my fork.
Important
If you are a new kickstart user, I would suggest you use those changes until they are merged into this repo.
I would try to keep this branch maintained until that point.
Those merged PRs include fixes for major and common reported issues (lsp for nvim 0.11, Mason 2.0, and guess-indent fix), as well as some non conversational (IMO) fixes and improvements (unlike my snacks PR :)
The merged PRs are:
virtual_linesfor discoverability #1463collapse_simple_statement#1484initkey #1582@feoh If the burnout is indeed my fault, I'm deeply sorry. Please accept this PR as an apology 😄
Let me know if there is anything else I could do to help.
Edit:
I now also merged these changes to dam9000's modular kickstart.
It can be found at the maintained-upstream-modular branch.