-
Notifications
You must be signed in to change notification settings - Fork 38.3k
Enhance Kickstart.nvim UX with Buffer Completions, Options, and Autocommands #1642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MN-nagy
wants to merge
5
commits into
nvim-lua:master
Choose a base branch
from
MN-nagy:improvments
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ddca0b4
Added blink.cmp buffer completions for markdown/text + some useful op…
MN-nagy 13ba71f
Updated filter files func in blink.cmp
MN-nagy 87d4ff8
Refactor: Use vim.o and adjust scrolling/wrapping options
MN-nagy c2347a5
Refactor: Removed duplicated opt; improve clarity with description
MN-nagy c61d50d
Refactor: updated colorcolum to a more appropriate value
MN-nagy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO this is not very useful because
<C-w>q
(which quits the window instead of the buffer) serves the purpose of closing splits, If I need to actually close buffers I usually use<M-d>
inside of Telescope'sbuffers
picker.What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback, I agree that
<C-w>q
and Telescope's buffer picker are good ways to manage windows and buffers in advanced workflows.However, since Kickstart.nvim is primarily aimed at users new to Neovim, I think keeping the
<leader>Q
mapping for:bd
is a good idea. as for many beginners, "closing a file" intuitively means closing the buffer, not just the window.