Skip to content

fix(path): improve & fix bugs in Path:rename() #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

fix(path): improve & fix bugs in Path:rename() #485

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7bd8300
WIP
tmillr May 3, 2023
0bee4b1
WIP
tmillr May 3, 2023
e890ac9
Return a new `Path` instance instead
tmillr May 3, 2023
a5ebe96
minor tweaks
tmillr May 3, 2023
25b0cc8
test(path): adapt and cleanup existing tests
tmillr May 4, 2023
fded248
fix(path): fix bug in `Path:copy()`
tmillr May 4, 2023
1f134d8
test(path): add tests for `Path:rename()`
tmillr May 4, 2023
c0bca33
add tests
tmillr May 4, 2023
1f233a6
test(path): cleanup comments
tmillr May 6, 2023
1e194ec
update annotations
tmillr May 7, 2023
8159983
remove `BUG` comment/tag
tmillr May 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions lua/plenary/path.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,15 +542,6 @@ function Path:rename(opts)
-- uses stat)
assert(self_lstat, ("%s: %s"):format(errmsg, self.filename))

-- BUG
-- handles `.`, `..`, `./`, and `../`
if opts.new_name:match "^%.%.?/?\\?.+" then
opts.new_name = {
uv.fs_realpath(opts.new_name:sub(1, 3)),
opts.new_name:sub(4),
}
end

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this as it contains a bug. Secondly, it is unnecessary, as uv.fs_rename already handles such relative paths.

local new_path = Path:new(opts.new_name)
new_lstat, errmsg = uv.fs_lstat(new_path.filename)

Expand Down