msys2 bruteforce path support #663
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in windows-style but due to possible skips of the Path module we can get posix-style path in 'job.lua' module as well. In my case I get stable Windows-style paths in 'harpoon' menu (no mixed slashes). The changes allow me to use git-related functions from Telescope but it also needs to be changed a bit cause it invokes 'vim.loop.spawn()' directly that leads to posix-style paths in the final command which WinAPI rejects. The changes are experimental cause integration with msys2 is fragile.
shikorido
added a commit
to shikorido/telescope.nvim
that referenced
this pull request
Jul 8, 2025
The patch assumes that `plenary.nvim` has the changes I made [in the corresponded PR](nvim-lua/plenary.nvim#663). At least for `plenary.utils` module usage and bruteforce paths conversions in internal logic. As stated in the `plenary`'s PR the msys2 integration is very fragile so I left all my comments and test notifies for further debugging.
11 tasks
shikorido
force-pushed
the
msys2-bruteforce-path-support
branch
4 times, most recently
from
6cb3f6a to
757818d
Compare
shikorido
added a commit
to shikorido/telescope.nvim
that referenced
this pull request
Jul 8, 2025
The patch assumes that `plenary.nvim` has the changes I made [in the corresponded PR](nvim-lua/plenary.nvim#663). At least for `plenary.utils` module usage and bruteforce paths conversions in internal logic. As stated in the `plenary`'s PR the msys2 integration is very fragile so I left all my comments and test notifies for further debugging.
…ath logic which I did not notice.
shikorido
force-pushed
the
msys2-bruteforce-path-support
branch
from
757818d to
00e5b4e
Compare
Using the same approach we can further refactor it focusing on drive paths conversion first and fallback to msys2 root mapping.
shikorido
force-pushed
the
msys2-bruteforce-path-support
branch
2 times, most recently
from
20f5538 to
43e4e02
Compare
shikorido
force-pushed
the
msys2-bruteforce-path-support
branch
from
43e4e02 to
a03a47c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verbose changes in
path.luamodule to be sure that the path will be in windows-stylebut due to possible skips of the
Pathmodule we can get posix-style path injob.luamodule as well.In my case I get stable Windows-style paths with backslashes (+correctly working relative paths) in
harpoonmenu.The changes allow me to use git-related functions from Telescope but it also needs to be changed a bit cause it invokes
vim.loop.spawn()directly that leads to posix-style paths in the final command which WinAPI rejects.The changes are experimental cause integration with msys2 is fragile.
Because of that I left all the comments and test notifies.