Add the ability to pass custom profiler options to profile.start
#665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #662. Please see the PR also for more context.
It looks like
p.startaccepts some profiler options, but it wasn't possible to pass them throughprofile.startin plenary. It was hard coded, but it would be great if we can also pass our own custom profiler options. That way people who use the profiler can change the settings easily.The main use case I had was to see the full paths of the Lua modules. I wanted to append
Fto the settings to make it work. With this option, I will be able to do it.For example, here's an example output I had with "10,i1,s,m0,F,p,G" as options: https://share.firefox.dev/460Xsdw
Thanks for the project!