fix(ALL): improve vim.str_utfindex and vim.str_byteindex usage
#2199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLeoP
commented
Dec 29, 2025
echasnovski
requested changes
Dec 29, 2025
Member
echasnovski
left a comment
echasnovski
left a comment
There was a problem hiding this comment.
Thanks for the PR! I did mean to do this, but didn't look like urgent.
echasnovski
approved these changes
Dec 29, 2025
Member
echasnovski
left a comment
echasnovski
left a comment
There was a problem hiding this comment.
Looks very neat now! Thank you so much!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1901
This includes a small shim (in each of the affected modules) that uses the new signature on Neovim >= 0.11. Let me know if a different approach would be preferred.