Open
Conversation
I notice that you have .luacheckrc and .stylua.toml files in the repo, but I found that my editor setup didn't honor them (this project is my first foray into lua). I pulled the common denominator settings that are supported by .editorconfig into a config file. I'm not sure if it's too redundant or an antipattern to also have the .editorconfig file in here, but it at least helped my format my code correctly for another PR I submitted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I notice that you have .luacheckrc and .stylua.toml files in the repo, but I found that my editor setup didn't honor them (this project is my first foray into lua). I pulled the common denominator settings that are supported by .editorconfig into a config file.
I'm not sure if it's too redundant or an antipattern to also have the .editorconfig file in here, but it at least helped my format my code correctly for another PR I submitted.