fix: remove hack that is causing validation not to appear #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I tested, but still see E5560 mentioned here with this patch. @ttytm Perhaps, have you installed a plugin that overwrites But also I think this hack is awkward. I will think another solution can solve this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the recently added hack the UI select for database validation stopped working. The PR removes the hack to restore the functionality.
The hack was introduced to resolve #246. But since it's not possible to reproduce the error the issue is mentioning and there were also other changes, it can be assumed that it was not the hack that has fixed the issue. So it should be removed since it introduces other conflicts.
Tested with nvim 10.1 and nightly(2024-09-06).