Skip to content

fix(linepipe):git_bcommit now can support customized command #2846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(linepipe):git_bcommit now can support customized command #2846

wants to merge 1 commit into from

Conversation

@Marskey
Copy link
Contributor

@Marskey Marskey commented Jan 4, 2024

Description

Fixes #2517

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Configuration:

  • Neovim version (nvim --version):0.9.4
  • Operating system and version:macos 12.4

Checklist:

  • My code follows the style guidelines of this project (stylua)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (lua annotations)

@Marskey Marskey force-pushed the fix/linepipe_parse_newline_fronted branch from ab0e7ee to c608ad5 Compare January 4, 2024 08:31
This was referenced May 6, 2025
Open
Closed
@emmanueltouzery
Copy link
Contributor

emmanueltouzery commented May 11, 2025

when reviewing this PR, please consider the alternative PR: #3465

I could be wrong, but I believe this PR drops the last non-newline terminated line of output, while #3465 doesn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Encountered an error when using git_command in git_bcommits

2 participants

@Marskey @emmanueltouzery