feat(pickers): improve center strategy by adding results_height option#3489
Open
alissonbrunosa wants to merge 4 commits intonvim-telescope:masterfrom
Open
feat(pickers): improve center strategy by adding results_height option#3489alissonbrunosa wants to merge 4 commits intonvim-telescope:masterfrom
results_height option#3489alissonbrunosa wants to merge 4 commits intonvim-telescope:masterfrom
Conversation
Changes: - Add `results_height` option to configure the number of lines the results panel/window should have. - Replaces calc_size_and_spacing with direct height adjustment based on border size and previewer status. - Refactors layout positioning to more clearly and correctly compute topline from the full height of prompt + results + preview. - Handles preview_cutoff explicitly, disabling the preview when too small and reallocating its height to results. - Adjust dropdown theme. height now sets the overall height intestead of just the result + prompt height.
results_height option
alissonbrunosa
commented
Jun 24, 2025
|
|
||
| height = function(_, _, max_lines) | ||
| return math.min(max_lines, 15) | ||
| return math.min(max_lines, 30) |
Author
There was a problem hiding this comment.
[ Note 🗒️ ]
Since the height option now sets the overall height and not just the prompt
+ results, we need to make it a bit taller and set the results_height to 15
to replicate the previous layout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I've been using this patched version of the
centerlayout strategy for a while and thought it was worth proposing upstream. It introduces a new layout option, results_height, allowing users to explicitly set the height of the results panel.In addition, this refactors how window dimensions and positions are calculated, properly centring the entire layout (including preview, results, and prompt), rather than just the prompt + results block.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I've tested this change with different configurations, such as
mirror,prompt_position,heightand with the new optionresults_heightDropdown theme
with
mirror = truewith
results_height = 5with
results_height = 5andmirror = truewith
prompt_position = 'bottom'with
height = 40andresults_height = 10Configuration
Checklist: