Skip to content

Fix vim.validate deprecation warnings in telescope.actions.utils #3502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Fix vim.validate deprecation warnings in telescope.actions.utils #3502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9d1ac9b
test(actions): add comprehensive tests for map_entries function valid…
Trishthedish Jul 9, 2025
2510bd8
test(actions): add TDD tests for vim.validate syntax modernization in…
Trishthedish Jul 9, 2025
6f3041b
fix(actions): migrate map_entries to use new vim.validate syntax
Trishthedish Jul 9, 2025
1d4b2fe
refactor(tests): improve test structure with proper setup/teardown fo…
Trishthedish Jul 9, 2025
bc4bee0
test(actions): add comprehensive tests for map_selections function va…
Trishthedish Jul 9, 2025
f67df31
test(actions): add TDD tests for vim.validate modernization in map_se…
Trishthedish Jul 9, 2025
6db9239
fix(actions): migrate map_selections to use new vim.validate syntax
Trishthedish Jul 9, 2025
82b7a88
style(utils_spec): apply stylua formatting suggestions
Trishthedish Jul 10, 2025
bc52cf2
test(actions): improve utils test coverage and organization
Trishthedish Jul 11, 2025
db597bb
chore(build): add test-utils target for focused utils testing
Trishthedish Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,6 @@ lint:

docgen:
nvim --headless --noplugin -u scripts/minimal_init.vim -c "luafile ./scripts/gendocs.lua" -c 'qa'

test-utils:
nvim --headless --noplugin -u scripts/minimal_init.vim -c "lua require('plenary.busted').run('lua/tests/automated/actions/utils_spec.lua', { minimal_init = './scripts/minimal_init.vim' })" -c "qa"
8 changes: 2 additions & 6 deletions lua/telescope/actions/utils.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,7 @@ local utils = {}
---@param prompt_bufnr number: The prompt bufnr
---@param f function: Function to map onto entries of picker that takes (entry, index, row) as viable arguments
function utils.map_entries(prompt_bufnr, f)
vim.validate {
f = { f, "function" },
}
vim.validate("f", f, "function")
local current_picker = action_state.get_current_picker(prompt_bufnr)
local index = 1
-- indices are 1-indexed, rows are 0-indexed
Expand Down Expand Up @@ -72,9 +70,7 @@ end
---@param prompt_bufnr number: The prompt bufnr
---@param f function: Function to map onto selection of picker that takes (selection) as a viable argument
function utils.map_selections(prompt_bufnr, f)
vim.validate {
f = { f, "function" },
}
vim.validate("f", f, "function")
local current_picker = action_state.get_current_picker(prompt_bufnr)
for _, selection in ipairs(current_picker:get_multi_selection()) do
f(selection)
Expand Down
Loading