fix: adjust to vim.validate deprecation in Nvim 0.12#3555
Merged
Conversation
27b7160 to
f697728
Compare
Contributor
Author
|
Note to self: dispatch outside of function definition, not inside. |
Contributor
|
Shouldn't the title be for |
Contributor
Author
|
No, because the deprecation message got added in 0.12. |
Contributor
|
Weird stuff, but I get it. |
clason
commented
Nov 4, 2025
| ---@return integer | ||
| utils.str_byteindex = function(s, i, encoding) | ||
| if vim.fn.has "nvim-0.11" == 1 then | ||
| return vim.str_byteindex(s, encoding, i, false) |
Contributor
Author
There was a problem hiding this comment.
nil is falsy in Lua, so we can use the same signature for both branches.
Contributor
Author
|
Follow-up (not critical but forward-looking):
|
418ac07 to
6d39931
Compare
makes it easier to remove later and minimizes branching
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requires #3552
Closes #3499