feat(enhancement): support nearest parent #603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isakbm
force-pushed
the
enhancement-nearest-parent
branch
from
2447efc to
52a8d81
Compare
lewis6991
reviewed
May 25, 2025
There was a problem hiding this comment.
Commit message should be prefixed with feat:. And like the last PR, please put issue references in the commit message summary on a separate line (see here)
I think we should remove the old behaviour and make this the new behaviour. Whether the context is being displayed in the context window or not shouldn't influence navigation.
isakbm
force-pushed
the
enhancement-nearest-parent
branch
from
52a8d81 to
31c0389
Compare
isakbm
changed the title
isakbm
changed the title
isakbm
force-pushed
the
enhancement-nearest-parent
branch
from
31c0389 to
63e1e45
Compare
lewis6991
reviewed
May 26, 2025
isakbm
force-pushed
the
enhancement-nearest-parent
branch
7 times, most recently
from
f9076a4 to
7102a3a
Compare
lewis6991
reviewed
May 27, 2025
isakbm
force-pushed
the
enhancement-nearest-parent
branch
4 times, most recently
from
452d8ac to
80ab4ce
Compare
lewis6991
reviewed
May 28, 2025
lewis6991
reviewed
May 28, 2025
isakbm
force-pushed
the
enhancement-nearest-parent
branch
4 times, most recently
from
5513c2b to
1253f55
Compare
isakbm
force-pushed
the
enhancement-nearest-parent
branch
from
1253f55 to
4495792
Compare
|
Any chance that this can get merged in @lewis6991 ? I've simplified it a lot, and avoided that extra list of ranges 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.