feat(render): add per-depth context highlight groups#656
Draft
TheRickyZhang wants to merge 1 commit intonvim-treesitter:masterfrom
Draft
feat(render): add per-depth context highlight groups#656TheRickyZhang wants to merge 1 commit intonvim-treesitter:masterfrom
TheRickyZhang wants to merge 1 commit intonvim-treesitter:masterfrom
Conversation
Author
|
^ I don't think the test failures are due to my changes? Could anyone confirm? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue #655
This currently hardcodes 8 context levels, as it is unlikely users will make use of more (falls back to base style). A possible improvement could be to implement a cycling mechanism if desired.
I'm not sure how to test the row-by-row depth coloring systematically in tests, so if that is possible or desired, then I can add that. Additionally, I have not investigated many edge cases like terminal vs GUI colors and theme overrides.