-
Notifications
You must be signed in to change notification settings - Fork 235
fix(shared) better inner parameter selection #702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 6 commits
c992e72
8fe7b1a
d1c6c18
e01a9fd
f589f74
e6cb041
02c0979
20b9df3
50a9b60
a9804be
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,6 +25,10 @@ describe("command equality Python:", function() | |
run:compare_cmds("aligned_indent.py", { row = 1, col = 0, cmds = { "dfn", "d;" } }) | ||
-- select using move | ||
run:compare_cmds("aligned_indent.py", { row = 1, col = 0, cmds = { "d]a", "v]ad", "c]a" } }) | ||
run:compare_cmds("selection_mode.py", { row = 2, col = 4, cmds = { "dam", "dVam", "vamd", "Vamd" } }) | ||
run:compare_cmds("selection_mode.py", { row = 2, col = 4, cmds = { "dam", "dVam", "vamd", "Vamd", "dG" } }) | ||
run:compare_cmds("selection_mode.py", { row = 3, col = 8, cmds = { "kdG", "dam", "dVam", "vamd", "Vamd" } }) | ||
|
||
run:compare_cmds("selection_mode.py", { row = 5, col = 8, cmds = { "dVao", "dao" } }, nil, false) | ||
run:compare_cmds("selection_mode.py", { row = 10, col = 17, cmds = { "dia", "dt," } }) | ||
run:compare_cmds("selection_mode.py", { row = 11, col = 23, cmds = { "dia", "d%" } }) | ||
run:compare_cmds("selection_mode.py", { row = 12, col = 23, cmds = { "dia", "d%" } }) | ||
end) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a brief comment on why the end_col_offset is needed (in what situation,) and a link to the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@przepompownia , can you address the requested comments by @kiyoon ?